From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 502BDC433FC for ; Mon, 27 Jul 2020 14:15:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A9142075A for ; Mon, 27 Jul 2020 14:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859337; bh=19mQB+PQDrdF584KAX767sTni5YlZ0N4xfTr5X9tToo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yGHRkECbCO1IARW25jjmBnkfZozNmbVl7iytnD3QYRyyVVW+syKNdFIdYcb+3FPZK osgxfgvPlo+f6i40YrIPkZ6N0H47Yrfe4phuoiqBBYH/O5hEWm5IxinWjH/UHBgJ1I H7i8TdM4C3qhFpQuH0Fw0X9lA5IWJ1016GPidtAQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730729AbgG0OPf (ORCPT ); Mon, 27 Jul 2020 10:15:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:41870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730120AbgG0OP2 (ORCPT ); Mon, 27 Jul 2020 10:15:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 769772083B; Mon, 27 Jul 2020 14:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859327; bh=19mQB+PQDrdF584KAX767sTni5YlZ0N4xfTr5X9tToo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0X4n+gqtoMBm/qbS3hOAweEdrh0VjomCn0UP/U33HD0Y0hUUgrRYyN+a40eKwIYRb xXlwbTOmSdnTl1RquSKttZ4lQlw3L5oth0CfNILgM9NKcwQag2XCBudS1rHqTJdf18 CPJc0TdSMX+OoMjFb0+4t+4x0RexphZT+WtSXyHY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kbuild test robot , Xu Yilun , Wu Hao , Tom Rix , Moritz Fischer , Sasha Levin Subject: [PATCH 5.4 038/138] fpga: dfl: pci: reduce the scope of variable ret Date: Mon, 27 Jul 2020 16:03:53 +0200 Message-Id: <20200727134927.279295285@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134925.228313570@linuxfoundation.org> References: <20200727134925.228313570@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xu Yilun [ Upstream commit e19485dc7a0d210b428a249c0595769bd495fb71 ] This is to fix lkp cppcheck warnings: drivers/fpga/dfl-pci.c:230:6: warning: The scope of the variable 'ret' can be reduced. [variableScope] int ret = 0; ^ drivers/fpga/dfl-pci.c:230:10: warning: Variable 'ret' is assigned a value that is never used. [unreadVariable] int ret = 0; ^ Fixes: 3c2760b78f90 ("fpga: dfl: pci: fix return value of cci_pci_sriov_configure") Reported-by: kbuild test robot Signed-off-by: Xu Yilun Acked-by: Wu Hao Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer Signed-off-by: Sasha Levin --- drivers/fpga/dfl-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c index 538755062ab7c..a78c409bf2c44 100644 --- a/drivers/fpga/dfl-pci.c +++ b/drivers/fpga/dfl-pci.c @@ -227,7 +227,6 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs) { struct cci_drvdata *drvdata = pci_get_drvdata(pcidev); struct dfl_fpga_cdev *cdev = drvdata->cdev; - int ret = 0; if (!num_vfs) { /* @@ -239,6 +238,8 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs) dfl_fpga_cdev_config_ports_pf(cdev); } else { + int ret; + /* * before enable SRIOV, put released ports into VF access mode * first of all. -- 2.25.1