From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77208C433F8 for ; Mon, 27 Jul 2020 14:21:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 446852173E for ; Mon, 27 Jul 2020 14:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859718; bh=x1iHGR1Nyu/ytLSpApmQTR1QQy7zYGQSZKRX+Z63DBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b+Ixsxqt7tAgDCXoRXGiYnE85Ac1T8dFK1J3HbjC9tk9w0K+aarYcbJNfBfJrQgg+ 9HbwZAni4lqg6jPIHt01tPjtc1HutdafLHfXPLsIZp3rKlXB3izR0fBkMdk7+GVpmz VUZLiPPWUgLDCdajp6/O1h2D7ObojUlQ/jqsudeA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731809AbgG0OV5 (ORCPT ); Mon, 27 Jul 2020 10:21:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:50666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731805AbgG0OVy (ORCPT ); Mon, 27 Jul 2020 10:21:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F6312173E; Mon, 27 Jul 2020 14:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859714; bh=x1iHGR1Nyu/ytLSpApmQTR1QQy7zYGQSZKRX+Z63DBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lj55AR01ARhDnwBd6aP2Egi+RXCo4Lqn96vb3RcUO9EQRtzVWQ6WW+Uj7xc5H926t 3KW+G8beg3y2ItV1ViSeirbAsID/84sSug8KecurQn8PBht/ROYOVk9FqNtX01hkfI wsPCTwx0a9CrLPWJYIfOasQvlT77XOcbjnz0r8Dg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Huang Guobin , "David S. Miller" , Sasha Levin Subject: [PATCH 5.7 076/179] net: ag71xx: add missed clk_disable_unprepare in error path of probe Date: Mon, 27 Jul 2020 16:04:11 +0200 Message-Id: <20200727134936.384343052@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134932.659499757@linuxfoundation.org> References: <20200727134932.659499757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huang Guobin [ Upstream commit befc113c56a76ae7be3986034a0e476d3385e265 ] The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when of_reset_control_get_exclusive() failed. Add the missed call to fix it. Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Reported-by: Hulk Robot Signed-off-by: Huang Guobin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/atheros/ag71xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index 02b7705393ca7..37a1cf63d9f7b 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -556,7 +556,8 @@ static int ag71xx_mdio_probe(struct ag71xx *ag) ag->mdio_reset = of_reset_control_get_exclusive(np, "mdio"); if (IS_ERR(ag->mdio_reset)) { netif_err(ag, probe, ndev, "Failed to get reset mdio.\n"); - return PTR_ERR(ag->mdio_reset); + err = PTR_ERR(ag->mdio_reset); + goto mdio_err_put_clk; } mii_bus->name = "ag71xx_mdio"; -- 2.25.1