Re: [PATCH 4.19 54/86] Input: elan_i2c - only increment wakeup count on touch

Dmitry Torokhov
2020-07-27T22:01:16Z

On Mon, Jul 27, 2020 at 11:29:33PM +0200, Pavel Machek wrote:
> Hi!
>
> > From: Derek Basehore <dbasehore@chromium.org>
> >
> > [ Upstream commit 966334dfc472bdfa67bed864842943b19755d192 ]
> >
> > This moves the wakeup increment for elan devices to the touch report.
> > This prevents the drivers from incorrectly reporting a wakeup when the
> > resume callback resets then device, which causes an interrupt to
> > occur.
>
> Contrary to the changelog, this does not move anything... unlike
> mainline, it simply adds two pm_wakeup_events.
>
> It may still be correct, but maybe someone wants to double-check?

Good catch, I believe the backport is busted.

Thanks.

--
Dmitry