Re: [PATCH 4.19 42/86] scripts/gdb: fix lx-symbols gdb.error while loading modules

Greg Kroah-Hartman
2020-07-27T17:14:04Z

On Mon, Jul 27, 2020 at 03:26:42PM +0100, Kieran Bingham wrote:
> Hi Greg, Sasha,
>
> On 27/07/2020 15:04, Greg Kroah-Hartman wrote:
> > From: Stefano Garzarella <sgarzare@redhat.com>
> >
> > [ Upstream commit 7359608a271ce81803de148befefd309baf88c76 ]
> >
> > Commit ed66f991bb19 ("module: Refactor section attr into bin attribute")
> > removed the 'name' field from 'struct module_sect_attr' triggering the
> > following error when invoking lx-symbols:
>
>
> Has ed66f991bb19 ("module: Refactor section attr into bin attribute")
> been backported to 4.19? It doesn't /sound/ like something that would
> require backporting unless something else depended up on it, but if it
> hasn't been ... then *this* patch shouldn't be either...

It was released in 4.19.133, 5.4.52, and 5.7.9.

> Same for 5.4, and 5.7 that's just come in.
>
> This patch will 'apply' cleanly, and not hit any compilation errors, as
> it only changes python code... so my reason to highlight is in case some
> automated system picked it up based on those assumptions.
>
> If ed66f991bb19 has also been backported, then I'm sorry for the noise ;-)

It was, but thanks for the review!

greg k-h