From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44796C4345B for ; Mon, 27 Jul 2020 23:29:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E1FF208E4 for ; Mon, 27 Jul 2020 23:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595892573; bh=2RNa96Lx3KsNfqNDjq9god52tZ1VPKcA7xclquJSil4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ezpL8NPw9L4i9BM56+V7TBIVX1nfum3WoWSesP9acfOicEFDDfEmD+uSuzbcNGUdq 89LtSeTVfJhCvoCuOxhu5E0pG1/u6Eq3waZZ5AutrISsmAlRHLiBxHrOp03xknfjfe vAKuanPdhQO7Y6cbnjAjHuRsmhPIoxszQ80hDmeY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728842AbgG0X3c (ORCPT ); Mon, 27 Jul 2020 19:29:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:40126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728053AbgG0X33 (ORCPT ); Mon, 27 Jul 2020 19:29:29 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26B70208E4; Mon, 27 Jul 2020 23:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595892569; bh=2RNa96Lx3KsNfqNDjq9god52tZ1VPKcA7xclquJSil4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uE0PAjHgPjzoetbsN/6so4DPgozOnmyKNvHU8W2xZw6FpPzgAAQTixICEsmfB9X0z hT+Q5UWXeUeetlHHpvTj1A9d2BBPGqq5Yr41q+ubCL8d4VERacmJcX0x7TL1JyzQ4m yit/0ZEtGmME0foyMvstdUdNlbtlw0cKb/mR7tkU= Date: Mon, 27 Jul 2020 19:29:28 -0400 From: Sasha Levin To: "dbasehore ." Cc: Dmitry Torokhov , Pavel Machek , Greg Kroah-Hartman , linux-kernel , stable@vger.kernel.org Subject: Re: [PATCH 4.19 54/86] Input: elan_i2c - only increment wakeup count on touch Message-ID: <20200727232928.GK406581@sasha-vm> References: <20200727134914.312934924@linuxfoundation.org> <20200727134917.124943291@linuxfoundation.org> <20200727212933.pkt6kgescdz7akht@duo.ucw.cz> <20200727220112.GV1665100@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 03:18:06PM -0700, dbasehore . wrote: >On Mon, Jul 27, 2020 at 3:01 PM Dmitry Torokhov > wrote: >> >> On Mon, Jul 27, 2020 at 11:29:33PM +0200, Pavel Machek wrote: >> > Hi! >> > >> > > From: Derek Basehore >> > > >> > > [ Upstream commit 966334dfc472bdfa67bed864842943b19755d192 ] >> > > >> > > This moves the wakeup increment for elan devices to the touch report. >> > > This prevents the drivers from incorrectly reporting a wakeup when the >> > > resume callback resets then device, which causes an interrupt to >> > > occur. >> > >> > Contrary to the changelog, this does not move anything... unlike >> > mainline, it simply adds two pm_wakeup_events. >> > >> > It may still be correct, but maybe someone wants to double-check? >> >> Good catch, I believe the backport is busted. > >I don't believe it will break anything, but the backport isn't needed >in 4.19 since "Input: elan_i2c - increment wakeup count if wake >source" wasn't merged into 4.19. It's probably best to drop the >backport. Hm, I wonder how this happened. It was just a cherry pick in this case :/ Either way, I've dropped it from 4.19, thanks! -- Thanks, Sasha