Re: [PATCH RFC 0/6] Add QCOM pwm-lpg and tri-led drivers

Pavel Machek
2020-07-24T22:05:21Z

[-- Attachment #1: Type: text/plain, Size: 1763 bytes --]

Hi!

Dalsi cech co hackuje LEDky?

> This series brings QCOM pwm-lpg and tri-led drivers from 4.14 that is required to support pmic-connected notification LED.
> This comes straight from downstream and I'm ready for your comments.

Yeah, so...

Bindings should go first, they may need to be converted to yml
(devicetree people will know).

Can generic pwm driver be used here?

This is for RGB modules, right? It will need to use multicolor
framework.

"Breathing" will need to be figured out. It should become a trigger.

Is this for phone, btw? If so, which one?

Best regards,
Pavel

> .../bindings/leds/leds-qti-tri-led.txt | 72 +
> .../devicetree/bindings/pwm/pwm-qti-lpg.txt | 163 +++
> drivers/leds/Kconfig | 9 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-qti-tri-led.c | 640 ++++++++
> drivers/pwm/Kconfig | 10 +
> drivers/pwm/Makefile | 1 +
> drivers/pwm/core.c | 56 +-
> drivers/pwm/pwm-qti-lpg.c | 1284 +++++++++++++++++
> drivers/pwm/sysfs.c | 56 +-
> include/linux/pwm.h | 144 +-
> 11 files changed, 2418 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-qti-tri-led.txt
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-qti-lpg.txt
> create mode 100644 drivers/leds/leds-qti-tri-led.c
> create mode 100644 drivers/pwm/pwm-qti-lpg.c
>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]