From: Mark Brown <broonie@kernel.org>
To: "RAVULAPATI, VISHNU VARDHAN RAO" <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Arnd Bergmann <arnd@arndb.de>,
open list <linux-kernel@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>, Takashi Iwai <tiwai@suse.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Agrawal, Akshu" <Akshu.Agrawal@amd.com>
Subject: Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682
Date: Tue, 28 Jul 2020 13:07:00 +0100 [thread overview]
Message-ID: <20200728120700.GA5055@sirena.org.uk> (raw)
In-Reply-To: <DM5PR1201MB01393D93D69F1552408BFE79E7730@DM5PR1201MB0139.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]
On Tue, Jul 28, 2020 at 06:59:50AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote:
> So Actually for rt5682 codec Now in 5.8 there are three flags :
> SND_SOC_RT5682
> SND_SOC_RT5682_I2C
> SND_SOC_RT5682_SDW
> But till 5.7.8 we have
> SND_SOC_RT5682
> SND_SOC_RT5682_SDW
> So in our design we were using SND_SOC_RT5682 which build snd_soc_rt5682.ko
> Creates the respective codec_dais as defined in that .ko
> If we use SND_SOC_RT5682_I2C we get snd_soc_rt5682_I2c.ko , it is not creating the expected codec_dai links.
Could you be more specific about the way in which "it is not creating
the expected codec_dai links" please? What are you expecting to happen
and what happens instead? Do you see any error messages for example?
> As there are three flags defined in codecs, I expect that previous one which we were using(SND_SOC_RT5682) is not a wrong flag and I expect to use
> SND_SOC_RT5682 as it is still available.
Given that the core module does not register with any bus it is
difficult to see how that could possibly work - the core module doesn't
contain a driver at all. Have you tested this change?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-28 12:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 14:58 [PATCH 1/6] ASoC: amd: Renaming snd-soc-card structure and fields Ravulapati Vishnu vardhan rao
2020-07-27 14:58 ` [PATCH 2/6] ASoC: amd: Passing card structure based on codec Ravulapati Vishnu vardhan rao
2020-07-27 14:58 ` [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682 Ravulapati Vishnu vardhan rao
2020-07-27 15:31 ` Pierre-Louis Bossart
2020-07-27 16:09 ` Mark Brown
2020-07-28 6:59 ` RAVULAPATI, VISHNU VARDHAN RAO
2020-07-28 12:07 ` Mark Brown [this message]
2020-07-28 12:18 ` Pierre-Louis Bossart
2020-07-28 15:24 ` RAVULAPATI, VISHNU VARDHAN RAO
2020-07-28 15:35 ` Mark Brown
2020-07-28 15:39 ` RAVULAPATI, VISHNU VARDHAN RAO
2020-07-27 14:58 ` [PATCH 4/6] ASoC: amd: Adding support for ALC1015 codec in machine driver Ravulapati Vishnu vardhan rao
2020-07-27 14:58 ` [PATCH 5/6] ASoC: amd: Adding DAI LINK for rt1015 codec Ravulapati Vishnu vardhan rao
2020-07-27 14:58 ` [PATCH 6/6] ASoC: amd: Added hw_params support for ALC1015 Ravulapati Vishnu vardhan rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728120700.GA5055@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Akshu.Agrawal@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=enric.balletbo@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox