Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

Arnaldo Carvalho de Melo
2020-07-28T15:22:18Z

Em Tue, Jul 28, 2020 at 03:01:00PM +0200, Jiri Olsa escreveu:
> On Tue, Jul 28, 2020 at 02:54:56PM +0200, Jiri Olsa wrote:
> > On Tue, Jul 28, 2020 at 09:39:55AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Mon, Jul 20, 2020 at 09:16:25PM +0200, Jiri Olsa escreveu:
> > > > On Mon, Jul 20, 2020 at 02:32:40PM +0530, kajoljain wrote:
> > > > > Hi jiri,
> > > > > We need power9 lpar machine and need to make sure `CONFIG_HV_PERF_CTRS` is
> > > > > enabled.

> > > > could you please try with following patch on top?

> > > So, can you point me to the cset that this should be merged into? Or can
> > > it come as a separate patch? I'll put what I have in the tmp.perf/core
> > > branch, and will do testing, please let me know if you want to fold it
> > > or as a followup patch.

> > sorry for delay.. I planned to squash the change in, but if you already
> > pushed something out, I'll rebase on top, I will post new version tomorrow

> > 1st 7 patches are good to go in any case

> ok, I just saw it's pushed out, I'll post a patch on top of it

See, the tmp.perf/core experimentation is about making it available what
would be just my local tree for wider consumption, what I have in
perf/core is what is non-rebase material, I try to push things there
only after testing and then recording the tests performed as signed
tags, see:

https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tag/?h=perf-tools-tests-2020-07-17

So if we find something wrong with material made available via my
tmp.perf/core branch, we can go back in time and fix it, to try and have
a more solid bisection base.

It may be confusing (it seems so from how you responded to this thread),
and if it ends up being so confusing, I'll just ditch it and go back to
having just local branches, would be a pity as I'm keen on having a good
bisection history so I'll probably take more time to publish things.

Opinions about this, of course, more than welcome.

Back to this specific case, when sending fixes for things in
tmp.perf/core, please state what is the cset that needs folding into.

Thanks,

- Arnaldo