From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D42C433E8 for ; Tue, 28 Jul 2020 16:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D80E02053B for ; Tue, 28 Jul 2020 16:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595955563; bh=ST3jWuFkG0CSvKv9iyNhigR7bR7h19swnEuLsvlSNtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ljlImU6cg4kUPFgTEgfKG34xXJ3Dy27qz+IeVa5L564UJyF+XlrABkZxv/AoW+abp xQik4peUqAqul141h1OEz3ORCUvj19TUmwavWX+2vD6ORFuWYWIQyBEIwhnA0MlnR/ sD+PkHF8LIftGGY0ZT+Ol9uRAs/RXzlCV3hsuTTw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731732AbgG1Q7X (ORCPT ); Tue, 28 Jul 2020 12:59:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:60068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731523AbgG1Q7U (ORCPT ); Tue, 28 Jul 2020 12:59:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9984220786; Tue, 28 Jul 2020 16:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595955560; bh=ST3jWuFkG0CSvKv9iyNhigR7bR7h19swnEuLsvlSNtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=feWGph0v83Feyg1UNLeoqkFE8DHV0ZuQPJtqOqQtXfKxlYIfuo/bbvgwjzCogOGef LwOmfDpbimOLkdZBfrljmnaN3lxwK6Q123BKcNcpEd6nF0w67ibb9rHnyJ9eoxK2rG dHozXIwlwuUHq9iKal2iRKjSftyPBZsCW7m7sY0A= Date: Tue, 28 Jul 2020 18:59:13 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Al Viro , Linus Torvalds , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 04/23] devtmpfs: refactor devtmpfsd() Message-ID: <20200728165913.GB42656@kroah.com> References: <20200728163416.556521-1-hch@lst.de> <20200728163416.556521-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200728163416.556521-5-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 06:33:57PM +0200, Christoph Hellwig wrote: > Split the main worker loop into a separate function. This allows > devtmpfsd_setup to be marked __init, which will allows us to call > __init routines for the setup work. devtmpfѕ itself needs a __ref > marker for that to work, and a comment explaining why it works. > > Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman