From: Prashant Malani <pmalani@chromium.org>
To: Azhar Shaikh <azhar.shaikh@intel.com>
Cc: bleung@chromium.org, enric.balletbo@collabora.com,
groeck@chromium.org, linux-kernel@vger.kernel.org,
heikki.krogerus@linux.intel.com, utkarsh.h.patel@intel.com,
casey.g.bowman@intel.com, rajmohan.mani@intel.com
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
Date: Tue, 28 Jul 2020 14:36:55 -0700 [thread overview]
Message-ID: <20200728213655.GC2996678@google.com> (raw)
In-Reply-To: <20200728212446.2699-1-azhar.shaikh@intel.com>
Hi Azhar,
On Tue, Jul 28, 2020 at 02:24:46PM -0700, Azhar Shaikh wrote:
> usb_role_switch_set_role() has the second argument as enum for usb_role.
> Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent.
> This eventually translates to USB_ROLE_NONE in case of UFP and
> USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum
> values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of
> UFP.
nit: DFP
>
> Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
> Cc: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_typec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 3eae01f4c9f7..eb4713b7ae14 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -590,7 +590,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
> dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
>
> return usb_role_switch_set_role(typec->ports[port_num]->role_sw,
> - !!(resp.role & PD_CTRL_RESP_ROLE_DATA));
> + resp.role & PD_CTRL_RESP_ROLE_DATA
> + ? USB_ROLE_HOST : USB_ROLE_DEVICE);
> }
>
> static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
> --
> 2.17.1
>
prev parent reply other threads:[~2020-07-28 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 21:24 [PATCH] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role() Azhar Shaikh
2020-07-28 21:36 ` Prashant Malani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728213655.GC2996678@google.com \
--to=pmalani@chromium.org \
--cc=azhar.shaikh@intel.com \
--cc=bleung@chromium.org \
--cc=casey.g.bowman@intel.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).