Re: [PATCH] habanalabs: fix up absolute include instructions

Greg Kroah-Hartman
2020-07-29T05:58:54Z

On Wed, Jul 29, 2020 at 08:09:38AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Tue, 28 Jul 2020 19:18:51 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > diff --git a/drivers/misc/habanalabs/common/Makefile b/drivers/misc/habanalabs/common/Makefile
> > index 97d03b5c8683..b984bfa4face 100644
> > --- a/drivers/misc/habanalabs/common/Makefile
> > +++ b/drivers/misc/habanalabs/common/Makefile
> > @@ -1,6 +1,4 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > -subdir-ccflags-y += -I$(src)/common
>
> I've seen oter places use
>
> subdir-ccflags-y += -I$(srcdir)/$(src)/common
>
> which would probably work as well. i.e. just change this in the
> Makefiles rather than every source file.

I hate seeing odd ccflags stuff in Makefiles as it can catch you "by
surprise" as to what exactly is happening when looking at .c code.

But yes, your change would also work.

thanks,

greg k-h