[PATCH kernel] panic: Dump registers on panic_on_warn

[PATCH kernel] panic: Dump registers on panic_on_warn

[Alexey Kardashevskiy]

Currently we print stack and registers for ordinary warnings but
we do not for panic_on_warn which looks as oversight - panic()
will reboot the machine but won't print registers.

This moves printing of registers and modules earlier.

This does not move the stack dumping as panic() dumps it.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 kernel/panic.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index e2157ca387c8..798eff8156f3 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -589,6 +589,11 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
 	if (args)
 		vprintk(args->fmt, args->args);
 
+	print_modules();
+
+	if (regs)
+		show_regs(regs);
+
 	if (panic_on_warn) {
 		/*
 		 * This thread may hit another WARN() in the panic path.
@@ -600,12 +605,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
 		panic("panic_on_warn set ...\n");
 	}
 
-	print_modules();
-
-	if (regs)
-		show_regs(regs);
-	else
-		dump_stack();
+	dump_stack();
 
 	print_irqtrace_events(current);
 
-- 
2.17.1

Re: [PATCH kernel] panic: Dump registers on panic_on_warn

[Alexey Kardashevskiy]

Ping?


On 30/06/2020 19:38, Alexey Kardashevskiy wrote:
> Currently we print stack and registers for ordinary warnings but
> we do not for panic_on_warn which looks as oversight - panic()
> will reboot the machine but won't print registers.
> 
> This moves printing of registers and modules earlier.
> 
> This does not move the stack dumping as panic() dumps it.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  kernel/panic.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/panic.c b/kernel/panic.c
> index e2157ca387c8..798eff8156f3 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -589,6 +589,11 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
>  	if (args)
>  		vprintk(args->fmt, args->args);
>  
> +	print_modules();
> +
> +	if (regs)
> +		show_regs(regs);
> +
>  	if (panic_on_warn) {
>  		/*
>  		 * This thread may hit another WARN() in the panic path.
> @@ -600,12 +605,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
>  		panic("panic_on_warn set ...\n");
>  	}
>  
> -	print_modules();
> -
> -	if (regs)
> -		show_regs(regs);
> -	else
> -		dump_stack();
> +	dump_stack();
>  
>  	print_irqtrace_events(current);
>  
> 

-- 
Alexey

Re: [PATCH kernel] panic: Dump registers on panic_on_warn

[Greg Kroah-Hartman]

On Wed, Jul 29, 2020 at 06:24:26PM +1000, Alexey Kardashevskiy wrote:
> Ping?
> 
> 
> On 30/06/2020 19:38, Alexey Kardashevskiy wrote:
> > Currently we print stack and registers for ordinary warnings but
> > we do not for panic_on_warn which looks as oversight - panic()
> > will reboot the machine but won't print registers.
> > 
> > This moves printing of registers and modules earlier.
> > 
> > This does not move the stack dumping as panic() dumps it.
> > 
> > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> > ---
> >  kernel/panic.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)

Why did you pick me and Nick as the people to get this patch?

Always use scripts/get_maintainer.pl please, that's what it is there
for...

thanks,

greg k-h