From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down
Date: Wed, 29 Jul 2020 11:09:40 +0100 [thread overview]
Message-ID: <20200729100940.GY1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200729174909.276590fb@xhacker.debian>
On Wed, Jul 29, 2020 at 05:49:09PM +0800, Jisheng Zhang wrote:
> mvneta has switched to phylink, so the comment should look
> like "We may have called phylink_speed_down before".
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> Since v1:
> - drop patch2 which tries to avoid link flapping when changing mtu
> I need more time on the change mtu refactoring.
>
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 2c9277e73cef..c9b6b0f85bb0 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)
>
> phylink_start(pp->phylink);
>
> - /* We may have called phy_speed_down before */
> + /* We may have called phylink_speed_down before */
> phylink_speed_up(pp->phylink);
>
> netif_tx_start_all_queues(pp->dev);
> --
> 2.28.0.rc0
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-07-29 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 9:49 [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down Jisheng Zhang
2020-07-29 10:09 ` Russell King - ARM Linux admin [this message]
2020-07-29 19:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729100940.GY1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Jisheng.Zhang@synaptics.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).