* [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down
@ 2020-07-29 9:49 Jisheng Zhang
2020-07-29 10:09 ` Russell King - ARM Linux admin
2020-07-29 19:17 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jisheng Zhang @ 2020-07-29 9:49 UTC (permalink / raw)
To: Thomas Petazzoni, David S. Miller, Jakub Kicinski, Russell King
Cc: netdev, linux-kernel
mvneta has switched to phylink, so the comment should look
like "We may have called phylink_speed_down before".
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
Since v1:
- drop patch2 which tries to avoid link flapping when changing mtu
I need more time on the change mtu refactoring.
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 2c9277e73cef..c9b6b0f85bb0 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)
phylink_start(pp->phylink);
- /* We may have called phy_speed_down before */
+ /* We may have called phylink_speed_down before */
phylink_speed_up(pp->phylink);
netif_tx_start_all_queues(pp->dev);
--
2.28.0.rc0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down
2020-07-29 9:49 [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down Jisheng Zhang
@ 2020-07-29 10:09 ` Russell King - ARM Linux admin
2020-07-29 19:17 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux admin @ 2020-07-29 10:09 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Thomas Petazzoni, David S. Miller, Jakub Kicinski, netdev,
linux-kernel
On Wed, Jul 29, 2020 at 05:49:09PM +0800, Jisheng Zhang wrote:
> mvneta has switched to phylink, so the comment should look
> like "We may have called phylink_speed_down before".
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> Since v1:
> - drop patch2 which tries to avoid link flapping when changing mtu
> I need more time on the change mtu refactoring.
>
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 2c9277e73cef..c9b6b0f85bb0 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)
>
> phylink_start(pp->phylink);
>
> - /* We may have called phy_speed_down before */
> + /* We may have called phylink_speed_down before */
> phylink_speed_up(pp->phylink);
>
> netif_tx_start_all_queues(pp->dev);
> --
> 2.28.0.rc0
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down
2020-07-29 9:49 [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down Jisheng Zhang
2020-07-29 10:09 ` Russell King - ARM Linux admin
@ 2020-07-29 19:17 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-07-29 19:17 UTC (permalink / raw)
To: Jisheng.Zhang; +Cc: thomas.petazzoni, kuba, linux, netdev, linux-kernel
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Date: Wed, 29 Jul 2020 17:49:09 +0800
> mvneta has switched to phylink, so the comment should look
> like "We may have called phylink_speed_down before".
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> Since v1:
> - drop patch2 which tries to avoid link flapping when changing mtu
> I need more time on the change mtu refactoring.
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-29 19:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-29 9:49 [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down Jisheng Zhang
2020-07-29 10:09 ` Russell King - ARM Linux admin
2020-07-29 19:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).