From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ankit Baluni <b18007@students.iitmandi.ac.in>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
sakari.ailus@linux.intel.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: media: atomisp: fixed a brace coding sytle issue
Date: Wed, 29 Jul 2020 13:56:22 +0300 [thread overview]
Message-ID: <20200729105622.GU3703480@smile.fi.intel.com> (raw)
In-Reply-To: <20200729074950.2104-1-b18007@students.iitmandi.ac.in>
On Wed, Jul 29, 2020 at 01:19:50PM +0530, Ankit Baluni wrote:
> Removed braces for a 'if' condition as it contain only single line &
> there is no need for braces for such case according to coding style
> rules.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
>
> ---
> Changes in v2:
> -Added more description about the patch.
> -Added space before the symobol '<' in 'From'
> and 'Signed-off-by' line.
> Changes in v3:
> -Removed space before ':' in subject line.
>
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 8ea65bef35d2..28b96b66f4f3 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
> case ATOMISP_CAMERA_PORT_SECONDARY:
> return MIPI_PORT1_ID;
> case ATOMISP_CAMERA_PORT_TERTIARY:
> - if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
> + if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
> return MIPI_PORT1_ID + 1;
> - }
> /* fall through */
> default:
> dev_err(isp->dev, "unsupported port: %d\n", port);
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-07-29 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 8:01 [PATCH] Staging : media : atomisp : pci : fixed a brace coding sytle issue Ankit
2020-07-27 12:16 ` Andy Shevchenko
2020-07-27 21:30 ` [PATCH] Staging : media : atomisp " Ankit
2020-07-28 7:37 ` Greg KH
2020-07-28 8:23 ` [PATCH v2] " Ankit
2020-07-28 8:43 ` Greg KH
2020-07-28 9:02 ` Ankit
2020-07-28 22:59 ` Ankit
2020-07-29 7:39 ` [PATCH v3] " Ankit Baluni
2020-07-29 7:45 ` Greg KH
2020-07-29 7:49 ` [PATCH v3] Staging: media: atomisp: " Ankit Baluni
2020-07-29 10:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729105622.GU3703480@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=b18007@students.iitmandi.ac.in \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox