Re: [PATCH v5 1/1] power: Emit changed uevent on wakeup_sysfs_add/remove

Greg Kroah-Hartman
2020-07-29T15:01:11Z

On Mon, Jul 27, 2020 at 03:38:02PM +0200, Rafael J. Wysocki wrote:
> On Thu, Jul 23, 2020 at 8:32 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Jul 07, 2020 at 10:28:44AM -0700, Abhishek Pandit-Subedi wrote:
> > > Udev rules that depend on the power/wakeup attribute don't get triggered
> > > correctly if device_set_wakeup_capable is called after the device is
> > > created. This can happen for several reasons (driver sets wakeup after
> > > device is created, wakeup is changed on parent device, etc) and it seems
> > > reasonable to emit a changed event when adding or removing attributes on
> > > the device.
> > >
> > > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> >
> > Rafael, any objection to this? Do you want me to take it through my
> > tree, or are you going to take it through yours? Either is fine for me.
>
> It's already there in my tree with the R-by tag from you.

{sigh} Sorry for the noise.

greg k-h