From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Oded Gabbay <oded.gabbay@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Omer Shpigelman <oshpigelman@habana.ai>,
Ofir Bitton <obitton@habana.ai>, Tomer Tayar <ttayar@habana.ai>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] habanalabs: make some functions static
Date: Wed, 29 Jul 2020 18:02:36 +0200 [thread overview]
Message-ID: <20200729160236.GA3643779@kroah.com> (raw)
In-Reply-To: <20200729155925.34131-1-weiyongjun1@huawei.com>
On Wed, Jul 29, 2020 at 11:59:25PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: warning:
> symbol 'gaudi_ctx_init' was not declared. Should it be static?
> drivers/misc/habanalabs/goya/goya.c:5228:5: warning:
> symbol 'goya_ctx_init' was not declared. Should it be static?
>
> Those functions are not used outside of source file, so this
> commit marks them static.
>
> Fixes: a04b7cd97eef ("habanalabs: create internal CB pool")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
0-day already sent this patch in earlier today, sorry.
greg k-h
prev parent reply other threads:[~2020-07-29 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 15:59 [PATCH -next] habanalabs: make some functions static Wei Yongjun
2020-07-29 16:02 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729160236.GA3643779@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=obitton@habana.ai \
--cc=oded.gabbay@gmail.com \
--cc=oshpigelman@habana.ai \
--cc=ttayar@habana.ai \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox