From: Julien Thierry <jthierry@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: jpoimboe@redhat.com, peterz@infradead.org, mhelsley@vmware.com,
mbenes@suse.cz, Julien Thierry <jthierry@redhat.com>
Subject: [PATCH v3 3/4] objtool: orc: Skip setting orc_entry for non-text sections
Date: Thu, 30 Jul 2020 10:41:42 +0100 [thread overview]
Message-ID: <20200730094143.27494-4-jthierry@redhat.com> (raw)
In-Reply-To: <20200730094143.27494-1-jthierry@redhat.com>
Orc generation is only done for text sections, but some instructions
can be found in non-text sections (e.g. .discard.text sections).
Skip setting their orc sections since their whole sections will be
skipped for orc generation.
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Julien Thierry <jthierry@redhat.com>
---
tools/objtool/orc_gen.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/objtool/orc_gen.c b/tools/objtool/orc_gen.c
index 968f55e6dd94..66fd56c33303 100644
--- a/tools/objtool/orc_gen.c
+++ b/tools/objtool/orc_gen.c
@@ -18,6 +18,9 @@ int create_orc(struct objtool_file *file)
struct cfi_reg *cfa = &insn->cfi.cfa;
struct cfi_reg *bp = &insn->cfi.regs[CFI_BP];
+ if (!insn->sec->text)
+ continue;
+
orc->end = insn->cfi.end;
if (cfa->base == CFI_UNDEFINED) {
--
2.21.3
next prev parent reply other threads:[~2020-07-30 9:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 9:41 [PATCH v3 0/4] Remove dependency of check subcmd upon orc Julien Thierry
2020-07-30 9:41 ` [PATCH v3 1/4] objtool: Move object file loading out of check Julien Thierry
2020-07-30 14:09 ` Josh Poimboeuf
2020-07-30 14:42 ` Julien Thierry
2020-07-30 9:41 ` [PATCH v3 2/4] objtool: Move orc outside " Julien Thierry
2020-07-30 9:57 ` peterz
2020-07-30 12:40 ` Julien Thierry
2020-07-30 13:22 ` peterz
2020-07-30 13:29 ` Julien Thierry
2020-07-30 14:15 ` Josh Poimboeuf
2020-07-30 14:44 ` Julien Thierry
2020-07-31 7:56 ` Miroslav Benes
2020-07-31 8:19 ` Julien Thierry
2020-07-30 9:41 ` Julien Thierry [this message]
2020-07-30 9:41 ` [PATCH v3 4/4] objtool: orc_gen: Move orc_entry out of instruction structure Julien Thierry
2020-07-30 10:03 ` peterz
2020-07-30 12:40 ` Julien Thierry
2020-07-30 13:33 ` peterz
2020-07-30 13:45 ` Julien Thierry
2020-07-30 14:28 ` Josh Poimboeuf
2020-07-30 14:06 ` [PATCH v3 0/4] Remove dependency of check subcmd upon orc Josh Poimboeuf
2020-07-30 14:42 ` Julien Thierry
2020-07-30 15:05 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730094143.27494-4-jthierry@redhat.com \
--to=jthierry@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mhelsley@vmware.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox