From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Oleg Nesterov <oleg@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Frederic Weisbecker <frederic@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [patch V3 1/3] posix-cpu-timers: Split run_posix_cpu_timers()
Date: Thu, 30 Jul 2020 12:14:05 +0200 [thread overview]
Message-ID: <20200730102337.677439437@linutronix.de> (raw)
In-Reply-To: 20200730101404.956367860@linutronix.de
From: Thomas Gleixner <tglx@linutronix.de>
Split it up as a preparatory step to move the heavy lifting out of
interrupt context.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/time/posix-cpu-timers.c | 43 ++++++++++++++++++++++-------------------
1 file changed, 24 insertions(+), 19 deletions(-)
--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -1080,32 +1080,15 @@ static inline bool fastpath_timer_check(
return false;
}
-/*
- * This is called from the timer interrupt handler. The irq handler has
- * already updated our counts. We need to check if any timers fire now.
- * Interrupts are disabled.
- */
-void run_posix_cpu_timers(void)
+static void __run_posix_cpu_timers(struct task_struct *tsk)
{
- struct task_struct *tsk = current;
struct k_itimer *timer, *next;
unsigned long flags;
LIST_HEAD(firing);
- lockdep_assert_irqs_disabled();
-
- /*
- * The fast path checks that there are no expired thread or thread
- * group timers. If that's so, just return.
- */
- if (!fastpath_timer_check(tsk))
+ if (!lock_task_sighand(tsk, &flags))
return;
- lockdep_posixtimer_enter();
- if (!lock_task_sighand(tsk, &flags)) {
- lockdep_posixtimer_exit();
- return;
- }
/*
* Here we take off tsk->signal->cpu_timers[N] and
* tsk->cpu_timers[N] all the timers that are firing, and
@@ -1147,6 +1130,28 @@ void run_posix_cpu_timers(void)
cpu_timer_fire(timer);
spin_unlock(&timer->it_lock);
}
+}
+
+/*
+ * This is called from the timer interrupt handler. The irq handler has
+ * already updated our counts. We need to check if any timers fire now.
+ * Interrupts are disabled.
+ */
+void run_posix_cpu_timers(void)
+{
+ struct task_struct *tsk = current;
+
+ lockdep_assert_irqs_disabled();
+
+ /*
+ * The fast path checks that there are no expired thread or thread
+ * group timers. If that's so, just return.
+ */
+ if (!fastpath_timer_check(tsk))
+ return;
+
+ lockdep_posixtimer_enter();
+ __run_posix_cpu_timers(tsk);
lockdep_posixtimer_exit();
}
next prev parent reply other threads:[~2020-07-30 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:14 [patch V3 0/3] posix-cpu-timers: Move expiry into task work context Thomas Gleixner
2020-07-30 10:14 ` Thomas Gleixner [this message]
2020-08-06 17:09 ` [tip: timers/core] posix-cpu-timers: Split run_posix_cpu_timers() tip-bot2 for Thomas Gleixner
2020-07-30 10:14 ` [patch V3 2/3] posix-cpu-timers: Provide mechanisms to defer timer handling to task_work Thomas Gleixner
2020-08-06 17:09 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2020-07-30 10:14 ` [patch V3 3/3] x86: Select POSIX_CPU_TIMERS_TASK_WORK Thomas Gleixner
2020-08-06 17:09 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2020-07-31 12:39 ` [patch V3 0/3] posix-cpu-timers: Move expiry into task work context Oleg Nesterov
2020-08-04 13:20 ` peterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730102337.677439437@linutronix.de \
--to=tglx@linutronix.de \
--cc=ebiederm@xmission.com \
--cc=frederic@kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=pbonzini@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox