Re: [PATCH v2] arm64/alternatives: move length validation inside the subsection

Nathan Chancellor
2020-07-30T16:57:45Z

On Thu, Jul 30, 2020 at 08:37:01AM -0700, 'Sami Tolvanen' via Clang Built Linux wrote:
> Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement
> sequences") breaks LLVM's integrated assembler, because due to its
> one-pass design, it cannot compute instruction sequence lengths before the
> layout for the subsection has been finalized. This change fixes the build
> by moving the .org directives inside the subsection, so they are processed
> after the subsection layout is known.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1078
> Fixes: f7b93d42945c ("arm64/alternatives: use subsections for replacement sequences")
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
> ---
> v1 -> v2:
> - Added the missing Fixes tag and dropped CC: stable@.

I think that the cc to stable should have been kept even with the
addition of the fixes tag. AUTOSEL will still most likely pick this up
(or even Chrome OS's patch bot that they now have) but the cc to stable
would have made it clear that we do need it there and the fixes tag
would have guided how far back it should go (rather than an explicit
version that is added).

Something for the future I supppose.

Cheers,
Nathan