From: Azhar Shaikh <azhar.shaikh@intel.com>
To: bleung@chromium.org, enric.balletbo@collabora.com,
groeck@chromium.org, pmalani@chromium.org,
linux-kernel@vger.kernel.org
Cc: heikki.krogerus@linux.intel.com, azhar.shaikh@intel.com,
utkarsh.h.patel@intel.com, casey.g.bowman@intel.com,
rajmohan.mani@intel.com
Subject: [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
Date: Thu, 30 Jul 2020 15:56:08 -0700 [thread overview]
Message-ID: <20200730225609.7395-2-azhar.shaikh@intel.com> (raw)
In-Reply-To: <20200730225609.7395-1-azhar.shaikh@intel.com>
usb_role_switch_set_role() has the second argument as enum for usb_role.
Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent.
This eventually translates to USB_ROLE_NONE in case of UFP and
USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum
values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of
DFP.
Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
Cc: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
---
drivers/platform/chrome/cros_ec_typec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 3eae01f4c9f7..eb4713b7ae14 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -590,7 +590,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
return usb_role_switch_set_role(typec->ports[port_num]->role_sw,
- !!(resp.role & PD_CTRL_RESP_ROLE_DATA));
+ resp.role & PD_CTRL_RESP_ROLE_DATA
+ ? USB_ROLE_HOST : USB_ROLE_DEVICE);
}
static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
--
2.17.1
next prev parent reply other threads:[~2020-07-30 22:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 22:56 [PATCH v2 0/2] TypeC Connector Class driver improvements Azhar Shaikh
2020-07-30 22:56 ` Azhar Shaikh [this message]
2020-07-30 22:59 ` [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role() Prashant Malani
2020-07-30 23:02 ` Shaikh, Azhar
2020-07-30 23:04 ` Prashant Malani
2020-07-30 23:14 ` Shaikh, Azhar
2020-07-30 23:18 ` Prashant Malani
2020-07-30 22:56 ` [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting usb role during disconnect Azhar Shaikh
2020-07-30 23:02 ` Prashant Malani
2020-07-30 23:06 ` Shaikh, Azhar
2020-07-30 23:25 ` Prashant Malani
2020-08-05 19:22 ` Shaikh, Azhar
2020-08-05 19:37 ` Prashant Malani
2020-08-05 20:28 ` Shaikh, Azhar
2020-08-06 0:57 ` Prashant Malani
2020-08-06 11:39 ` Heikki Krogerus
2020-08-06 18:39 ` Prashant Malani
2020-08-11 13:07 ` Heikki Krogerus
2020-08-11 19:39 ` Shaikh, Azhar
2020-08-05 9:09 ` [PATCH v2 0/2] TypeC Connector Class driver improvements Heikki Krogerus
-- strict thread matches above, loose matches on Subject: below --
2020-07-30 22:52 Azhar Shaikh
2020-07-30 22:52 ` [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role() Azhar Shaikh
2020-07-31 13:33 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730225609.7395-2-azhar.shaikh@intel.com \
--to=azhar.shaikh@intel.com \
--cc=bleung@chromium.org \
--cc=casey.g.bowman@intel.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=rajmohan.mani@intel.com \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox