From: Prashant Malani <pmalani@chromium.org>
To: "Shaikh, Azhar" <azhar.shaikh@intel.com>
Cc: "bleung@chromium.org" <bleung@chromium.org>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"groeck@chromium.org" <groeck@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"Patel, Utkarsh H" <utkarsh.h.patel@intel.com>,
"Bowman, Casey G" <casey.g.bowman@intel.com>,
"Mani, Rajmohan" <rajmohan.mani@intel.com>
Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting usb role during disconnect
Date: Thu, 30 Jul 2020 16:25:04 -0700 [thread overview]
Message-ID: <20200730232504.GG3145664@google.com> (raw)
In-Reply-To: <MWHPR11MB1518178C5B2335FC02CD36AE91710@MWHPR11MB1518.namprd11.prod.outlook.com>
Hey Azhar,
On Thu, Jul 30, 2020 at 11:06:12PM +0000, Shaikh, Azhar wrote:
> Hi Prashant,
> >
> > Since this was the last switch being configured, please maintain the same
> > order and add this at the end of the function, after the if-else if block.
> >
>
> Please correct if my understanding is not correct here:
> Set the orientation , set the role, then configure the mux. Shouldn't this be the order?
Is this documented anywhere? Kindly provide the links to that if so. I
wasn't aware of any ordering requirements (but I may be missing something).
Please keep in mind that each of these switches (orientation, data-role,
mode-switch, or what is referred to here as "mux") can theoretically be
different switches, controlled independently by distinct drivers and
hardware.
We should not change what ordering is already present unless there is a
requirement to do so. The existing ordering was orientation switch, "mux" or role switch,
then the data-role switch, so let us stick to that.
Best regards,
>
>
> > Best regards,
> >
> > -Prashant
next prev parent reply other threads:[~2020-07-30 23:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 22:56 [PATCH v2 0/2] TypeC Connector Class driver improvements Azhar Shaikh
2020-07-30 22:56 ` [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role() Azhar Shaikh
2020-07-30 22:59 ` Prashant Malani
2020-07-30 23:02 ` Shaikh, Azhar
2020-07-30 23:04 ` Prashant Malani
2020-07-30 23:14 ` Shaikh, Azhar
2020-07-30 23:18 ` Prashant Malani
2020-07-30 22:56 ` [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting usb role during disconnect Azhar Shaikh
2020-07-30 23:02 ` Prashant Malani
2020-07-30 23:06 ` Shaikh, Azhar
2020-07-30 23:25 ` Prashant Malani [this message]
2020-08-05 19:22 ` Shaikh, Azhar
2020-08-05 19:37 ` Prashant Malani
2020-08-05 20:28 ` Shaikh, Azhar
2020-08-06 0:57 ` Prashant Malani
2020-08-06 11:39 ` Heikki Krogerus
2020-08-06 18:39 ` Prashant Malani
2020-08-11 13:07 ` Heikki Krogerus
2020-08-11 19:39 ` Shaikh, Azhar
2020-08-05 9:09 ` [PATCH v2 0/2] TypeC Connector Class driver improvements Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730232504.GG3145664@google.com \
--to=pmalani@chromium.org \
--cc=azhar.shaikh@intel.com \
--cc=bleung@chromium.org \
--cc=casey.g.bowman@intel.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox