Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

[daniel@ffwll.ch]

On Wed, Jul 29, 2020 at 02:28:01AM +0200, Paul Cercueil wrote:
> 
> 
> Le mer. 29 juil. 2020 à 0:00, daniel@ffwll.ch a écrit :
> > On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote:
> > >  Hi Paul.
> > > 
> > >  On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote:
> > >  > Here are a few cleanups to the ingenic-drm driver.
> > >  > - some error paths were missing and have been added;
> > >  > - the mode validation has been moved to the .mode_valid helper
> > > callback.
> > >  >
> > >  > Cheers,
> > >  > -Paul
> > >  >
> > >  > Paul Cercueil (2):
> > >  >   drm/ingenic: Handle errors of drm_atomic_get_plane_state
> > >  >   drm/ingenic: Validate mode in a .mode_valid callback
> > > 
> > >  Both looks fine, you can add my:
> > >  Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > > 
> > >  I assume you will apply the patches.
> > >  Maybe wait for Daniel to take a look, he had some feedback on where
> > >  to add checks. I assume this is covered by the second patch.
> > 
> > Yeah changelog for new versions would be great, but aside from that
> > bickering patch 2 lgtm now.
> 
> This patchset is V1, I'm fixing issues you saw in the ingenic-drm driver
> when reviewing a different patchset.

Oh right that was pre-existing issue in which callback to use, apologies
for the confusion.
-Daniel

> 
> Thanks for the review, I'll apply now.
> 
> -Paul
> > 
> 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch