From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 3/3] lib/vsprintf: Force type of flags for gfp_t
Date: Fri, 31 Jul 2020 15:31:45 +0300 [thread overview]
Message-ID: <20200731123145.22357-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200731123145.22357-1-andriy.shevchenko@linux.intel.com>
Sparse is not happy about restricted type being assigned:
lib/vsprintf.c:1940:23: warning: incorrect type in assignment (different base types)
lib/vsprintf.c:1940:23: expected unsigned long [assigned] flags
lib/vsprintf.c:1940:23: got restricted gfp_t [usertype]
Force type of flags to make sparse happy.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/vsprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 90d818ef03c5..118e2727d058 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1937,7 +1937,7 @@ char *flags_string(char *buf, char *end, void *flags_ptr,
names = vmaflag_names;
break;
case 'g':
- flags = *(gfp_t *)flags_ptr;
+ flags = (__force typeof(flags))(*(gfp_t *)flags_ptr);
names = gfpflag_names;
break;
default:
--
2.27.0
next prev parent reply other threads:[~2020-07-31 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 12:31 [PATCH v1 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Andy Shevchenko
2020-07-31 12:31 ` [PATCH v1 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one Andy Shevchenko
2020-07-31 15:15 ` Steven Rostedt
2020-07-31 15:48 ` Andy Shevchenko
2020-07-31 12:31 ` Andy Shevchenko [this message]
2020-07-31 15:34 ` [PATCH v1 3/3] lib/vsprintf: Force type of flags for gfp_t Steven Rostedt
2020-07-31 15:49 ` Andy Shevchenko
2020-07-31 16:04 ` Steven Rostedt
2020-07-31 14:38 ` [PATCH v1 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Steven Rostedt
2020-07-31 15:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731123145.22357-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox