From: josh@joshtriplett.org
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jessica Yu <jeyu@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: inherit TAINT_PROPRIETARY_MODULE v2
Date: Fri, 31 Jul 2020 13:11:46 -0700 [thread overview]
Message-ID: <20200731201146.GA34345@localhost> (raw)
In-Reply-To: <20200730061027.29472-1-hch@lst.de>
Christoph Hellwig wrote:
> we've had a bug in our resolution of _GPL modules since day one, that
> is a module can claim to be GPL licensed and use _GPL exports, while
> it also depends on symbols from non-GPL modules. This is used as a
> circumvention of the _GPL exports by using a small shim module using
> the _GPL exports and the other functionality.
This looks great. You might also consider doing the reverse: if a module
imports any EXPORT_SYMBOL_GPL symbols, any symbols that module in turn
exports shouldn't be importable by any module that doesn't explicitly
claim to be GPL-compatible. Effectively, if a module imports any
EXPORT_SYMBOL_GPL symbols, all of its exported symbols would then be
treated as EXPORT_SYMBOL_GPL.
This would catch the case of attempting to "wrap" EXPORT_SYMBOL_GPL
symbols in the other direction, by re-exporting the same or similar
functions to another module. (This would help catch mistakes, not just
intentional malice.)
- Josh Triplett
next prev parent reply other threads:[~2020-07-31 20:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 6:10 inherit TAINT_PROPRIETARY_MODULE v2 Christoph Hellwig
2020-07-30 6:10 ` [PATCH 1/8] modules: mark ref_module static Christoph Hellwig
2020-07-30 6:10 ` [PATCH 2/8] modules: mark find_symbol static Christoph Hellwig
2020-07-30 6:10 ` [PATCH 3/8] modules: mark each_symbol_section static Christoph Hellwig
2020-07-30 6:10 ` [PATCH 4/8] modules: unexport __module_text_address Christoph Hellwig
2020-07-30 6:10 ` [PATCH 5/8] modules: unexport __module_address Christoph Hellwig
2020-07-30 6:10 ` [PATCH 6/8] modules: rename the licence field in struct symsearch to license Christoph Hellwig
2020-07-30 6:10 ` [PATCH 7/8] modules: return licensing information from find_symbol Christoph Hellwig
2020-07-30 6:10 ` [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE Christoph Hellwig
2020-07-30 14:12 ` Jessica Yu
2020-07-30 16:29 ` Christoph Hellwig
2020-07-31 8:51 ` Jessica Yu
2020-07-31 9:00 ` Christoph Hellwig
2020-07-31 9:01 ` Jessica Yu
2020-08-04 18:52 ` daniel
2020-07-31 20:11 ` josh [this message]
2020-08-01 6:53 ` inherit TAINT_PROPRIETARY_MODULE v2 Christoph Hellwig
2020-08-01 8:16 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731201146.GA34345@localhost \
--to=josh@joshtriplett.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox