Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

Chris Wilson
2020-08-02T11:51:51Z

Quoting Andi Shyti (2020-08-02 12:40:44)
> Hi Tianjia,
>
> > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c
> > index d960d0be5bd2..cc017e3cc9c5 100644
> > --- a/drivers/gpu/drm/i915/i915_active.c
> > +++ b/drivers/gpu/drm/i915/i915_active.c
> > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct i915_active *ref,
> > intel_engine_mask_t tmp, mask = engine->mask;
> > struct llist_node *first = NULL, *last = NULL;
> > struct intel_gt *gt = engine->gt;
> > - int err;
> > + int err = 0;
>
> you don't need the initialization here.

But it's close enough that I can munge the patch inline.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris