[PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()

[PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()

[Ashutosh Dixit]

Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:

551:58: warning: incorrect type in argument 1 (different address spaces)
551:58:    expected void const volatile [noderef] __iomem *addr
551:58:    got restricted __le64 *
560:49: warning: incorrect type in argument 1 (different address spaces)
560:49:    expected struct mic_device_ctrl *dc
560:49:    got struct mic_device_ctrl [noderef] __iomem *dc
579:49: warning: incorrect type in argument 1 (different address spaces)
579:49:    expected struct mic_device_ctrl *dc
579:49:    got struct mic_device_ctrl [noderef] __iomem *dc

Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 drivers/misc/mic/vop/vop_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
index 85942f6717c5..25ed7d731701 100644
--- a/drivers/misc/mic/vop/vop_main.c
+++ b/drivers/misc/mic/vop/vop_main.c
@@ -546,7 +546,7 @@ static int vop_match_desc(struct device *dev, void *data)
 	return vdev->desc == (void __iomem *)data;
 }
 
-static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl *dc)
+static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl __iomem *dc)
 {
 	return (struct _vop_vdev *)(unsigned long)readq(&dc->vdev);
 }
-- 
2.26.2.108.g048abe1751

Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()

[Greg Kroah-Hartman]

On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
> 
> 551:58: warning: incorrect type in argument 1 (different address spaces)
> 551:58:    expected void const volatile [noderef] __iomem *addr
> 551:58:    got restricted __le64 *
> 560:49: warning: incorrect type in argument 1 (different address spaces)
> 560:49:    expected struct mic_device_ctrl *dc
> 560:49:    got struct mic_device_ctrl [noderef] __iomem *dc
> 579:49: warning: incorrect type in argument 1 (different address spaces)
> 579:49:    expected struct mic_device_ctrl *dc
> 579:49:    got struct mic_device_ctrl [noderef] __iomem *dc
> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Cc: stable <stable@vger.kernel.org>

Why is this a stable thing?  It doesn't fix a real bug, and sparse
warnings are not needed for stable trees, unless this is the last sparse
warning there.

thanks,

greg k-h

Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()

[Dixit, Ashutosh]

On Sun, 02 Aug 2020 21:24:01 -0700, Greg Kroah-Hartman wrote:
>
> On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> > Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
> >
> > 551:58: warning: incorrect type in argument 1 (different address spaces)
> > 551:58:    expected void const volatile [noderef] __iomem *addr
> > 551:58:    got restricted __le64 *
> > 560:49: warning: incorrect type in argument 1 (different address spaces)
> > 560:49:    expected struct mic_device_ctrl *dc
> > 560:49:    got struct mic_device_ctrl [noderef] __iomem *dc
> > 579:49: warning: incorrect type in argument 1 (different address spaces)
> > 579:49:    expected struct mic_device_ctrl *dc
> > 579:49:    got struct mic_device_ctrl [noderef] __iomem *dc
> >
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> > Cc: stable <stable@vger.kernel.org>
>
> Why is this a stable thing?  It doesn't fix a real bug, and sparse
> warnings are not needed for stable trees, unless this is the last sparse
> warning there.

It is the last sparse warning. Sorry I wasn't sure about stable so I
thought might as well. Please ignore if it's not required. Thanks.

Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()

[Michael S. Tsirkin]

On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
> 
> 551:58: warning: incorrect type in argument 1 (different address spaces)
> 551:58:    expected void const volatile [noderef] __iomem *addr
> 551:58:    got restricted __le64 *
> 560:49: warning: incorrect type in argument 1 (different address spaces)
> 560:49:    expected struct mic_device_ctrl *dc
> 560:49:    got struct mic_device_ctrl [noderef] __iomem *dc
> 579:49: warning: incorrect type in argument 1 (different address spaces)
> 579:49:    expected struct mic_device_ctrl *dc
> 579:49:    got struct mic_device_ctrl [noderef] __iomem *dc
> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  drivers/misc/mic/vop/vop_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
> index 85942f6717c5..25ed7d731701 100644
> --- a/drivers/misc/mic/vop/vop_main.c
> +++ b/drivers/misc/mic/vop/vop_main.c
> @@ -546,7 +546,7 @@ static int vop_match_desc(struct device *dev, void *data)
>  	return vdev->desc == (void __iomem *)data;
>  }
>  
> -static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl *dc)
> +static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl __iomem *dc)
>  {
>  	return (struct _vop_vdev *)(unsigned long)readq(&dc->vdev);
>  }
> -- 
> 2.26.2.108.g048abe1751