From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D19C433E3 for ; Mon, 3 Aug 2020 09:47:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EED020738 for ; Mon, 3 Aug 2020 09:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596448039; bh=qpoO7T4TWxeK1V2SJCvaQW+4GFglH2BYvug32jHLcZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LB7o1CT42gybWNTBqDzGhO7OhaUj8k5Yhsduz6PVKZ/bZPM8vXB5nCkPixuV1qjnD 1uc6+W5MWPm5ul1Lr+oipU+WYmVPTmHPy+/k0fVojTLCKKuVakUfoIlFloxq6e4Lrs pKPSyFmmhmPaN3x5eRKHxnsyKkXNmcRUCU8z4dZI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726568AbgHCJrR (ORCPT ); Mon, 3 Aug 2020 05:47:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:58608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbgHCJrQ (ORCPT ); Mon, 3 Aug 2020 05:47:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B64F20738; Mon, 3 Aug 2020 09:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596448035; bh=qpoO7T4TWxeK1V2SJCvaQW+4GFglH2BYvug32jHLcZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zU9zbElCn+GDWj9AK06UOK2yvPDIFQRnBSPFL1gsvV7ntZT2E+Qcj7+sR9u9055C9 GOYSqzYAeHn84+krzQ6mCctixn+MEBOBB5hcNYXVTKX3hbxQkaaILpXh8oUPpTzXKw dNSfKmXr7k4bNv9LkmHODqNtcGWvICQTnAfedGNA= Date: Mon, 3 Aug 2020 11:46:59 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Qu Wenruo , Heikki Krogerus Subject: Re: [PATCH v2] kobject: Restore old behaviour of kobject_del(NULL) Message-ID: <20200803094659.GB635660@kroah.com> References: <20200803082706.65347-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200803082706.65347-1-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 03, 2020 at 11:27:06AM +0300, Andy Shevchenko wrote: > The commit 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in > kobject_cleanup()") inadvertently dropped a possibility to call kobject_del() > with NULL pointer. Restore the old behaviour. > > Fixes: 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in kobject_cleanup()") > Reported-by: Qu Wenruo > Cc: Heikki Krogerus > Signed-off-by: Andy Shevchenko > --- > v2: replaced ?: with plain conditional (Greg) > lib/kobject.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Thanks, much better, will queue up after -rc1 is out. greg k-h