Re: [RESEND PATCH 1/2] audit: change unnecessary globals into statics

Paul Moore
2020-08-06T18:35:01Z

On Mon, Aug 3, 2020 at 8:35 AM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> Variables sig_pid, audit_sig_uid and audit_sig_sid
> are only used in the audit.c file across the kernel
> Hence it appears no reason for declaring them as globals
> This patch removes their global declarations from the .h file
> and change them into static in the .c file.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> kernel/audit.c | 6 +++---
> kernel/audit.h | 4 ----
> 2 files changed, 3 insertions(+), 7 deletions(-)

Thanks Jules, this looks reasonable although I'm not going to merge
them into audit/next until after the merge window closes. I'll send
another reply once this has been merged.

--
paul moore