From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64324C433DF for ; Mon, 3 Aug 2020 15:08:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40618207DF for ; Mon, 3 Aug 2020 15:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596467296; bh=Lrbi2rsIAExF59EuLBc7ucnI9amz38W6mCJdKugNiSY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nAvifxSS+eRf64gv84ZOonE4WNk/lzJLtAnwaHHrf6sg+boNc/GOGZIct9rc1TAFL w3JYfeev+CbPVFIKJkWT10L8RjtB9MV379pitN3nhLvLtBu5g4n9yxOoQQdp6/q5YM MCVm7Gm5Yyke9WeEnpafUHGX2iyS/s1xKa7qgt7s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728031AbgHCPIQ (ORCPT ); Mon, 3 Aug 2020 11:08:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:49036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbgHCPIP (ORCPT ); Mon, 3 Aug 2020 11:08:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C71A12076E; Mon, 3 Aug 2020 15:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596467294; bh=Lrbi2rsIAExF59EuLBc7ucnI9amz38W6mCJdKugNiSY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ICoWVarNkJzobZx++tnhhJngFcae6r4xhlEqj89aatZag49QjN5O7mXay7bxj7NCH JQE6yTT6PfFgtOkugp3ORwOlnC4/BgyQYnlSHTNw08W/1cT7W8D1WHH92PsbDVprvw hGrE+qO9QSqdzq+k0XSsdZeJMweV3FqiiRp79DUg= Date: Mon, 3 Aug 2020 17:07:56 +0200 From: Greg KH To: Dongdong Yang Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, devel@driverdev.osuosl.org, gulinghua@xiaomi.com, tanggeliang@xiaomi.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, yangdongdong@xiaomi.com, duhui@xiaomi.com, zhangguoquan@xiaomi.com, fengwei@xiaomi.com, taojun@xiaomi.com, rocking@linux.alibaba.com, huangqiwu@xiaomi.com Subject: Re: [PATCH v3] sched: Provide USF for the portable equipment. Message-ID: <20200803150756.GA1098726@kroah.com> References: <23719695ee476715ec54d3310c95d535f8e1391a.1596464896.git.yangdongdong@xiaomi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23719695ee476715ec54d3310c95d535f8e1391a.1596464896.git.yangdongdong@xiaomi.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 03, 2020 at 10:31:15PM +0800, Dongdong Yang wrote: > + /* > + * create a sched_usf in cpu_subsys: > + * /sys/devices/system/cpu/sched_usf/... I thought I asked you not to use a "raw" kobject, you are making this much harder than it has to be. Just use a normal struct device. Also you failed to document your new sysfs files in Documentation/ABI/ like is required :( Because of both of those things, this isn't ok as-is, sorry. greg k-h