Re: [PATCH 1/2] vdso: allow to add architecture-specific vdso data

Thomas Gleixner
2020-08-03T12:13:17Z

Sven,

Sven Schnelle <svens@linux.ibm.com> writes:
> source "scripts/gcc-plugins/Kconfig"
> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
> index 7955c56d6b3c..74e730238ce6 100644
> --- a/include/vdso/datapage.h
> +++ b/include/vdso/datapage.h
> @@ -19,6 +19,10 @@
> #include <vdso/time32.h>
> #include <vdso/time64.h>
>
> +#ifdef CONFIG_ARCH_HAS_VDSO_DATA
> +#include <asm/vdso/data.h>
> +#endif
> +
> #define VDSO_BASES (CLOCK_TAI + 1)
> #define VDSO_HRES (BIT(CLOCK_REALTIME) | \
> BIT(CLOCK_MONOTONIC) | \
> @@ -97,6 +101,9 @@ struct vdso_data {
> s32 tz_dsttime;
> u32 hrtimer_res;
> u32 __unused;
> +#ifdef CONFIG_ARCH_HAS_VDSO_DATA
> + struct arch_vdso_data arch;
> +#endif

just a few nits.

Can you please spare that #ifdef and do:

#ifdef CONFIG_ARCH_HAS_VDSO_DATA
#include <asm/vdso/data.h>
#else
struct arch_vdso_data {};
#endif

Please keep the tabular alignment of the struct members and add kernel
doc in the comment above the struct.

Aside of that 'arch' is not really a intuitive name. 'arch_data' or
something like that. Hmm?

Thanks,

tglx