* Re: [PATCH] siganl: ignore other signals when doing coredump
[not found] ` <1596185654.11648.1.camel@mbjsdccf07>
@ 2020-08-03 19:17 ` Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2020-08-03 19:17 UTC (permalink / raw)
To: chunlei.wang
Cc: Andrew Morton, Matthias Brugger, Peter Zijlstra, Aneesh Kumar K.V,
Will Deacon, linux-mediatek, wsd_upstream, weiwei.zhang,
linux-kernel
On 07/31, chunlei.wang wrote:
>
> Please tell us much more about why you think Linux would benefit from
> this change. Precisely what operational problems are you seeing with
> the current code?
> =>
> Sorry for the late reply.
>
> If coredump is incomplete, R&D can not find root cause through
> coredump.
> If the issue is seldom, this modification will speed up the process of
> solving the problem.
To be honest, I do not even know what can I say, except that I disagree
with this change. The very idea looks wrong to me.
Granted, SIGKILL can kill the process which does something useful. Say,
dumps a core. So what?
Where does this SIGKILL come from? How often does this happen?
And why do you think the core dumping is special? Say, you try to debug
the buggy application, but a sudden SIGKILL kills the debuggee and you
lose the debugging session. Does this mean that the kernel needs another
patch to protect the process running under gdb from SIGKILL?
I don't think so. Please feel free to resend this patch, but it needs
a very convincing changelog. And please send it to lkml.
Oleg.
^ permalink raw reply [flat|nested] only message in thread