public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v3 3/4] KVM: SVM: Add GHCB Accessor functions
Date: Mon, 3 Aug 2020 23:02:10 +0200	[thread overview]
Message-ID: <20200803210210.GA12917@8bytes.org> (raw)
In-Reply-To: <20200803184545.GG3151@linux.intel.com>

Hi Sean,

On Mon, Aug 03, 2020 at 11:45:45AM -0700, Sean Christopherson wrote:
> On Mon, Aug 03, 2020 at 02:27:07PM +0200, Joerg Roedel wrote:
> > +		return test_bit(GHCB_BITMAP_IDX(field),				\
> > +				(unsigned long *)&(ghcb)->save.valid_bitmap);	\
> 
> 'ghcb' doesn't need to be wrapped in (), it's a parameter to a function.

Thanks for your reviews, I addressed them and sent v4.

Regards,

	Joerg


  reply	other threads:[~2020-08-03 21:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 12:27 [PATCH v3 0/4] KVM: SVM: SEV-ES groundwork Joerg Roedel
2020-08-03 12:27 ` [PATCH v3 1/4] KVM: SVM: nested: Don't allocate VMCB structures on stack Joerg Roedel
2020-08-03 18:04   ` Sean Christopherson
2020-08-03 12:27 ` [PATCH v3 2/4] KVM: SVM: Add GHCB definitions Joerg Roedel
2020-08-03 18:17   ` Sean Christopherson
2020-08-03 12:27 ` [PATCH v3 3/4] KVM: SVM: Add GHCB Accessor functions Joerg Roedel
2020-08-03 18:45   ` Sean Christopherson
2020-08-03 21:02     ` Joerg Roedel [this message]
2020-08-03 12:27 ` [PATCH v3 4/4] KVM: SVM: Use __packed shorthand Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803210210.GA12917@8bytes.org \
    --to=joro@8bytes.org \
    --cc=jmattson@google.com \
    --cc=jroedel@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=thomas.lendacky@amd.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox