Re: [PATCH v11 00/28] Add support for mt2701 JPEG ENC support

Hans Verkuil
2020-08-05T08:46:01Z

On 04/08/2020 05:40, Xia Jiang wrote:
> This patchset add support for mt2701 JPEG ENC support.

I'm getting these compile warnings/errors:

drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_enc_device_run’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:917:27: warning: variable ‘jpeg_src_buf’ set but not used [-Wunused-but-set-variable]

917 | struct mtk_jpeg_src_buf *jpeg_src_buf;
| ^~~~~~~~~~~~

It's indeed not used.

drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_suspend’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1482:2: error: implicit declaration of function ‘v4l2_m2m_suspend’; did you mean ‘v4l2_m2m_mmap’? [-Werror=implicit-function-declaration]

1482 | v4l2_m2m_suspend(jpeg->m2m_dev);
| ^~~~~~~~~~~~~~~~
| v4l2_m2m_mmap
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_resume’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1495:2: error: implicit declaration of function ‘v4l2_m2m_resume’; did you mean ‘v4l2_m2m_release’? [-Werror=implicit-function-declaration]

1495 | v4l2_m2m_resume(jpeg->m2m_dev);
| ^~~~~~~~~~~~~~~
| v4l2_m2m_release

This apparently relies on https://lore.kernel.org/linux-arm-kernel/20191204124732.10932-2-Jerry-Ch.chen@mediatek.com/

Please add this patch to this series. Don't forget to add Tomasz' 'Reviewed-by' line.

drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_enc_g_selection’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:525:8: warning: this statement may fall through [-Wimplicit-fallthrough=]

525 | s->r = ctx->out_q.enc_crop_rect;
| ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:526:2: note: here
526 | case V4L2_SEL_TGT_CROP_BOUNDS:
| ^~~~

This is definitely wrong. A break is missing here.

Regards,

Hans