From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6891EC433DF for ; Tue, 4 Aug 2020 10:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6800E2086A for ; Tue, 4 Aug 2020 10:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726877AbgHDKUg (ORCPT ); Tue, 4 Aug 2020 06:20:36 -0400 Received: from foss.arm.com ([217.140.110.172]:42222 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725856AbgHDKUf (ORCPT ); Tue, 4 Aug 2020 06:20:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4A13D1FB; Tue, 4 Aug 2020 03:20:35 -0700 (PDT) Received: from bogus (unknown [10.37.12.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A5A83F718; Tue, 4 Aug 2020 03:20:33 -0700 (PDT) Date: Tue, 4 Aug 2020 11:20:25 +0100 From: Sudeep Holla To: Jason Liu Cc: will@kernel.org, catalin.marinas@arm.com, ashal@kernel.org, maz@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked Message-ID: <20200804102025.GA15199@bogus> References: <20200804085657.10776-1-jason.hui.liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200804085657.10776-1-jason.hui.liu@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Marc Z On Tue, Aug 04, 2020 at 04:56:57PM +0800, Jason Liu wrote: > No need to do the irq_chip->irq_mask() if it already masked. > BTW, unconditionally do the irq_chip->irq_mask() will also bring issues > when the irq_chip in the runtime PM suspend. Accessing registers of the > irq_chip will bring in the exceptions. For example on the i.MX: > The change looks good and is inline with the additional checks we do for eoi and disable. However, the imx_irqsteer_irq_mask is not safe to be called with runtime suspend. What happens if some driver using the irq on this chip calls disable_irq when this irqchip is suspended ? -- Regards, Sudeep