From: Greg KH <gregkh@linuxfoundation.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled
Date: Tue, 4 Aug 2020 13:32:32 +0200 [thread overview]
Message-ID: <20200804113232.GA164292@kroah.com> (raw)
In-Reply-To: <20200804111332.dex7jobmabifdzw5@function>
On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote:
> Drivers using serialio are already made available in Kconfig only under
> the ISA condition.
>
> This solves warnings in inb/outb macros on platform that do not have
> support for ISA.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> Index: linux-2.6/drivers/accessibility/speakup/Makefile
> ===================================================================
> --- linux-2.6.orig/drivers/accessibility/speakup/Makefile
> +++ linux-2.6/drivers/accessibility/speakup/Makefile
> @@ -16,6 +16,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += spe
> obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o
>
> obj-$(CONFIG_SPEAKUP) += speakup.o
> +obj-$(CONFIG_ISA) += serialio.o
> speakup-y := \
> buffers.o \
> devsynth.o \
> @@ -25,7 +26,6 @@ speakup-y := \
> keyhelp.o \
> kobjects.o \
> selection.o \
> - serialio.o \
> spk_ttyio.o \
> synth.o \
> thread.o \
Nice, this should fix the riscv build issues.
I'll go merge this now, and hold on to the first patch until this round
gets merged with Linus.
thanks,
greg k-h
next prev parent reply other threads:[~2020-08-04 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 11:13 [PATCH 2/2] speakup: only build serialio when ISA is enabled Samuel Thibault
2020-08-04 11:32 ` Greg KH [this message]
2020-08-04 11:34 ` Greg KH
2020-08-04 11:49 ` Samuel Thibault
2020-08-04 11:56 ` Greg KH
2020-08-04 11:58 ` Greg KH
2020-08-04 15:35 ` Samuel Thibault
2020-08-04 15:49 ` Greg KH
2020-08-04 16:11 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804113232.GA164292@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox