From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled
Date: Tue, 4 Aug 2020 13:49:51 +0200 [thread overview]
Message-ID: <20200804114951.ijs3hnezi4f64nll@function> (raw)
In-Reply-To: <20200804113413.GA181242@kroah.com>
Greg KH, le mar. 04 août 2020 13:34:13 +0200, a ecrit:
> On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote:
> > Drivers using serialio are already made available in Kconfig only under
> > the ISA condition.
> >
> > This solves warnings in inb/outb macros on platform that do not have
> > support for ISA.
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> >
> > Index: linux-2.6/drivers/accessibility/speakup/Makefile
> > ===================================================================
> > --- linux-2.6.orig/drivers/accessibility/speakup/Makefile
> > +++ linux-2.6/drivers/accessibility/speakup/Makefile
> > @@ -16,6 +16,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += spe
> > obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o
> >
> > obj-$(CONFIG_SPEAKUP) += speakup.o
> > +obj-$(CONFIG_ISA) += serialio.o
> > speakup-y := \
> > buffers.o \
> > devsynth.o \
> > @@ -25,7 +26,6 @@ speakup-y := \
> > keyhelp.o \
> > kobjects.o \
> > selection.o \
> > - serialio.o \
> > spk_ttyio.o \
> > synth.o \
> > thread.o \
>
> Oops, no, I get the following build errors with this patch:
>
> ERROR: modpost: "spk_wait_for_xmitr" [drivers/accessibility/speakup/speakup.ko] undefined!
Yes, it depends on the first of the queue.
Samuel
next prev parent reply other threads:[~2020-08-04 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 11:13 [PATCH 2/2] speakup: only build serialio when ISA is enabled Samuel Thibault
2020-08-04 11:32 ` Greg KH
2020-08-04 11:34 ` Greg KH
2020-08-04 11:49 ` Samuel Thibault [this message]
2020-08-04 11:56 ` Greg KH
2020-08-04 11:58 ` Greg KH
2020-08-04 15:35 ` Samuel Thibault
2020-08-04 15:49 ` Greg KH
2020-08-04 16:11 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804114951.ijs3hnezi4f64nll@function \
--to=samuel.thibault@ens-lyon.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox