From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Gutson <daniel@eclypsium.com>
Cc: Derek Kiernan <derek.kiernan@xilinx.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Richard Hughes <hughsient@gmail.com>,
Alex Bazhaniuk <alex@eclypsium.com>
Subject: Re: [PATCH] Platform lockdown information in SYSFS
Date: Tue, 4 Aug 2020 18:42:46 +0200 [thread overview]
Message-ID: <20200804164246.GA502540@kroah.com> (raw)
In-Reply-To: <CAFmMkTFEWrMsigabvE2HtmpFXMe0qb8QZJHzMzQ=wZXE1G3fbQ@mail.gmail.com>
On Tue, Aug 04, 2020 at 11:37:02AM -0300, Daniel Gutson wrote:
> static void mypci_remove(struct pci_dev *pdev)
> {
> /*
> I tried enabling and disabling this
> if (child_device != NULL) {
> put_device(child_device);
> device_unregister(child_device);
> }
> */
You can just call device_destroy() here, but this should be the same.
But, if you have it commented out, that's not good, you have to clean
this up.
> class_remove_file(&my_class, &class_attr_howareyou);
You don't always have to remove files you create, but it doesn't hurt.
> class_unregister(&my_class);
class_destroy()? But this is the same as well, so all is good.
Try running without the above code commented out.
greg k-h
next prev parent reply other threads:[~2020-08-04 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 21:41 [PATCH] Platform lockdown information in SYSFS Daniel Gutson
2020-07-30 22:33 ` Randy Dunlap
2020-07-30 22:40 ` Daniel Gutson
2020-07-31 7:00 ` Greg Kroah-Hartman
2020-07-31 13:30 ` Daniel Gutson
2020-07-31 14:15 ` Greg Kroah-Hartman
2020-08-03 22:04 ` Daniel Gutson
2020-08-04 6:41 ` Greg Kroah-Hartman
2020-08-04 13:50 ` Daniel Gutson
2020-08-04 14:22 ` Greg Kroah-Hartman
[not found] ` <CAFmMkTFEWrMsigabvE2HtmpFXMe0qb8QZJHzMzQ=wZXE1G3fbQ@mail.gmail.com>
2020-08-04 14:44 ` Greg Kroah-Hartman
2020-08-04 15:05 ` Daniel Gutson
2020-08-04 15:51 ` Greg Kroah-Hartman
2020-08-04 16:42 ` Greg Kroah-Hartman [this message]
2020-08-04 17:37 ` Daniel Gutson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804164246.GA502540@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex@eclypsium.com \
--cc=arnd@arndb.de \
--cc=daniel@eclypsium.com \
--cc=derek.kiernan@xilinx.com \
--cc=hughsient@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox