Re: [PATCH v3 3/3] s390: convert to GENERIC_VDSO

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3028 bytes --]

Hi Sven,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on s390/features]
[also build test ERROR on tip/timers/core linus/master v5.8 next-20200804]
[cannot apply to tip/timers/vdso]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sven-Schnelle/vdso-allow-to-add-architecture-specific-vdso-data/20200805-000148
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/vdso/datapage.h:136,
                    from arch/s390/include/asm/vdso.h:5,
                    from arch/s390/include/asm/elf.h:147,
                    from include/linux/elf.h:6,
                    from include/linux/module.h:18,
                    from arch/s390/include/asm/kvm_host.h:21,
                    from include/linux/kvm_host.h:36,
                    from arch/s390/kernel/asm-offsets.c:11:
   arch/s390/include/asm/vdso/gettimeofday.h: In function '__arch_get_hw_counter':
>> arch/s390/include/asm/vdso/gettimeofday.h:31:12: error: 'const struct vdso_data' has no member named 'arch'
      31 |  adj = vdso->arch.tod_steering_end - now;
         |            ^~
   arch/s390/include/asm/vdso/gettimeofday.h:33:15: error: 'const struct vdso_data' has no member named 'arch'
      33 |   now += (vdso->arch.tod_steering_delta < 0) ? (adj >> 15) : -(adj >> 15);
         |               ^~
   make[2]: *** [scripts/Makefile.build:114: arch/s390/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1176: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:185: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +31 arch/s390/include/asm/vdso/gettimeofday.h

    24	
    25	static inline u64 __arch_get_hw_counter(s32 clock_mode)
    26	{
    27		const struct vdso_data *vdso = __arch_get_vdso_data();
    28		u64 adj, now;
    29	
    30		now = get_tod_clock();
  > 31		adj = vdso->arch.tod_steering_end - now;
    32		if (unlikely((s64) adj > 0))
    33			now += (vdso->arch.tod_steering_delta < 0) ? (adj >> 15) : -(adj >> 15);
    34		return now;
    35	}
    36	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62780 bytes --]