From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B542DC433E0 for ; Wed, 5 Aug 2020 08:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99C4A21744 for ; Wed, 5 Aug 2020 08:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726918AbgHEIsN (ORCPT ); Wed, 5 Aug 2020 04:48:13 -0400 Received: from foss.arm.com ([217.140.110.172]:56058 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbgHEIsL (ORCPT ); Wed, 5 Aug 2020 04:48:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 273B7D6E; Wed, 5 Aug 2020 01:48:11 -0700 (PDT) Received: from bogus (unknown [10.37.12.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1750C3F6CF; Wed, 5 Aug 2020 01:48:08 -0700 (PDT) Date: Wed, 5 Aug 2020 09:47:57 +0100 From: Sudeep Holla To: Jason Liu Cc: Marc Zyngier , "catalin.marinas@arm.com" , "will@kernel.org" , "sashal@kernel.org" , "linux-kernel@vger.kernel.org" , Sudeep Holla , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked Message-ID: <20200805084748.GA4818@bogus> References: <20200804085657.10776-1-jason.hui.liu@nxp.com> <20200804113850.GB15199@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2020 at 06:31:20AM +0000, Jason Liu wrote: > > > > Indeed, the runtime PM ops in that driver looks dodgy. Any calls to mask_irq > > from drivers or anywhere with irqchip suspended with just blows up the > > system. > > If you look at the chip->irq_mask implementation on different platforms, almost > all with directly access the register of the irqchip including irqsteer. > There are fine due to driver will use the common mask_irq API. > That still doesn't explain how you can prevent system from blowing up if chip->irq_mask gets called with irqchip suspended ? -- Regards, Sudeep