* [PATCH] habanalabs: Fix a loop in gaudi_extract_ecc_info()
@ 2020-08-05 9:51 Dan Carpenter
2020-08-05 10:20 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-08-05 9:51 UTC (permalink / raw)
To: Oded Gabbay
Cc: Arnd Bergmann, Greg Kroah-Hartman, Omer Shpigelman, Ofir Bitton,
Tomer Tayar, linux-kernel, kernel-janitors
The condition was reversed. It should have been less than instead of
greater than. The result is that we never enter the loop.
Fixes: fcc6a4e60678 ("habanalabs: Extract ECC information from FW")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index 00a0a7238d81..de2f81b80ced 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -5215,7 +5215,7 @@ static int gaudi_extract_ecc_info(struct hl_device *hdev,
*memory_wrapper_idx = 0xFF;
/* Iterate through memory wrappers, a single bit must be set */
- for (i = 0 ; i > num_mem_regs ; i++) {
+ for (i = 0 ; i < num_mem_regs ; i++) {
err_addr += i * 4;
err_word = RREG32(err_addr);
if (err_word) {
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] habanalabs: Fix a loop in gaudi_extract_ecc_info()
2020-08-05 9:51 [PATCH] habanalabs: Fix a loop in gaudi_extract_ecc_info() Dan Carpenter
@ 2020-08-05 10:20 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2020-08-05 10:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: Arnd Bergmann, Greg Kroah-Hartman, Omer Shpigelman, Ofir Bitton,
Tomer Tayar, Linux-Kernel@Vger. Kernel. Org, kernel-janitors
On Wed, Aug 5, 2020 at 12:51 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The condition was reversed. It should have been less than instead of
> greater than. The result is that we never enter the loop.
>
> Fixes: fcc6a4e60678 ("habanalabs: Extract ECC information from FW")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
> index 00a0a7238d81..de2f81b80ced 100644
> --- a/drivers/misc/habanalabs/gaudi/gaudi.c
> +++ b/drivers/misc/habanalabs/gaudi/gaudi.c
> @@ -5215,7 +5215,7 @@ static int gaudi_extract_ecc_info(struct hl_device *hdev,
> *memory_wrapper_idx = 0xFF;
>
> /* Iterate through memory wrappers, a single bit must be set */
> - for (i = 0 ; i > num_mem_regs ; i++) {
> + for (i = 0 ; i < num_mem_regs ; i++) {
> err_addr += i * 4;
> err_word = RREG32(err_addr);
> if (err_word) {
> --
> 2.27.0
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Thanks!
Applied to -fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-05 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-05 9:51 [PATCH] habanalabs: Fix a loop in gaudi_extract_ecc_info() Dan Carpenter
2020-08-05 10:20 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox