From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E7AC433E0 for ; Wed, 5 Aug 2020 19:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D548D2076E for ; Wed, 5 Aug 2020 19:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mPCsyVau" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728970AbgHETvS (ORCPT ); Wed, 5 Aug 2020 15:51:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728112AbgHEQw7 (ORCPT ); Wed, 5 Aug 2020 12:52:59 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B0FDC0A8895 for ; Wed, 5 Aug 2020 06:55:48 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f7so40830290wrw.1 for ; Wed, 05 Aug 2020 06:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ja++vUWPJ08EOA6SgZWSzzzNGHnYWDLpTD9FHTxS0rw=; b=mPCsyVauudhQuP/KJCzACLzD1hGJ28aiHs4qkIVT+dJsG9lMfuT7dSoXYJbFizKZRP kR2I6h/RpqcqrsXsr0WOQrAgDwfnAX/8FSgglt/yxTXrl83b60/gxayRpC2euEgFfaQN aKk3SV25A7zijFrcxS9Y8ftx/QbxX1RciA4Z8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ja++vUWPJ08EOA6SgZWSzzzNGHnYWDLpTD9FHTxS0rw=; b=YLy363nUIkCOzd6VjVp+4sPb5IutYkMQiLloaqRkdmuu61SR2J4KrTsckTPJqcZLEu gUfrTyoeYwULRBdBDJsSV0DwSN1o4D2xv6FVzcfv5RPVbLosufQ24jQnsrEcUOIVh+cq g3lexNhyuMwrfvWui/BWAMV3E+Bu3QHVe0wlsuUYFXh/9IZXlvLyaS+7KwHQBhYVKBcS 1ysKvdptOFCi2k8aBncQiAnIxJirSZ988k7rAbkcVKnd3uXSs5t6dkVdBJciJzckee+w WdOncfzcHfc8m8SjyED7f6CmV2nP1Fm62Hr1erVqLUk2cP9x6vypfPTrkmBFXxl1uhL5 25Zg== X-Gm-Message-State: AOAM531AgqocASB/Xwl9IKCNcYxs+t2NYhhgYY0iILe5X4rjaL5qYgSS hjnMC8n3CV1clRMdGxY6G7VE8A== X-Google-Smtp-Source: ABdhPJxYNtjsQJjSF6xJ7nBQbZo3fBriXEe6OI14ms3Hr23UwjYAMHhqsXQOBERea4H+jC1NM69TBw== X-Received: by 2002:a5d:5485:: with SMTP id h5mr2759249wrv.427.1596635746822; Wed, 05 Aug 2020 06:55:46 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id p14sm3039630wrg.96.2020.08.05.06.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 06:55:46 -0700 (PDT) Date: Wed, 5 Aug 2020 13:55:44 +0000 From: Tomasz Figa To: Xia Jiang Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Rick Chang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Marek Szyprowski , srv_heupstream@mediatek.com, senozhatsky@chromium.org, mojahsu@chromium.org, drinkcat@chromium.org, maoguang.meng@mediatek.com Subject: Re: [PATCH v11 22/28] media: platform: Change the call functions of getting/enable/disable the jpeg's clock Message-ID: <20200805135544.GA1014704@chromium.org> References: <20200804034102.22983-1-xia.jiang@mediatek.com> <20200804034102.22983-23-xia.jiang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200804034102.22983-23-xia.jiang@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xia, On Tue, Aug 04, 2020 at 11:40:56AM +0800, Xia Jiang wrote: > Use the generic clk_bulk_* helpers to enable and disable clocks. > > Signed-off-by: Xia Jiang > --- > v11: specify the names of the clocks in the driver > --- > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 28 +++++++++++++------ > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 8 +++--- > 2 files changed, 23 insertions(+), 13 deletions(-) > Thank you for the patch. It looks good to me. Reviewed-by: Tomasz Figa One comment below about a thing that should be fixed in the future, separately from this series. > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index 7881e9c93df7..47d570f32e3f 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -783,14 +783,15 @@ static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg) > ret = mtk_smi_larb_get(jpeg->larb); > if (ret) > dev_err(jpeg->dev, "mtk_smi_larb_get larbvdec fail %d\n", ret); > - clk_prepare_enable(jpeg->clk_jdec_smi); > - clk_prepare_enable(jpeg->clk_jdec); > + > + ret = clk_bulk_prepare_enable(jpeg->num_clks, jpeg->clks); > + if (ret) > + dev_err(jpeg->dev, "Failed to open jpeg clk: %d\n", ret); The errors in this function should be propagated to the caller and handled properly across the whole call stack. Best regards, Tomasz