From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696A9C433DF for ; Wed, 5 Aug 2020 21:25:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42B1222CA1 for ; Wed, 5 Aug 2020 21:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726398AbgHEVZF (ORCPT ); Wed, 5 Aug 2020 17:25:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44374 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbgHEVZE (ORCPT ); Wed, 5 Aug 2020 17:25:04 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k3Qu8-008Qez-Ev; Wed, 05 Aug 2020 23:24:56 +0200 Date: Wed, 5 Aug 2020 23:24:56 +0200 From: Andrew Lunn To: Joe Perches Cc: Russell King - ARM Linux admin , Linus Torvalds , Dmitry Vyukov , Linux Kernel Mailing List , Netdev Subject: Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching Message-ID: <20200805212456.GC2005851@lunn.ch> References: <20200805182250.GX1551@shell.armlinux.org.uk> <957f48692a2f0bc4df2d83068073c4822da30eef.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <957f48692a2f0bc4df2d83068073c4822da30eef.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2020 at 11:47:38AM -0700, Joe Perches wrote: > On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wrote: > > On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > > > On Wed, Aug 5, 2020 at 7:34 AM Russell King wrote: > > > > Is this something you're willing to merge directly please? > > > > > > Done. > > > > > > That said: > > > > > > > -K: phylink > > > > +K: phylink\.h|struct\s+phylink|\.phylink|>phylink_|phylink_(autoneg|clear|connect|create|destroy|disconnect|ethtool|helper|mac|mii|of|set|start|stop|test|validate) > > > > > > That's a very awkward pattern. I wonder if there could be better ways > > > to express this (ie "only apply this pattern to these files" kind of > > > thing) > > > > Yes, it's extremely awkward - I spent much of the morning with perl > > testing it out on the drivers/ subtree. > > There are a lot of phylink_ in the kernel. > Are those really the only uses you want to watch? Hi Joe I think Rusells intention here is to match on MAC drivers which make use of the phylink API exported to them. SFF/SFP/SFP+ MODULE SUPPORT M: Russell King L: netdev@vger.kernel.org S: Maintained F: drivers/net/phy/phylink.c F: drivers/net/phy/sfp* F: include/linux/phylink.h F: include/linux/sfp.h K: phylink > $ git grep -P -oh 'phylink_\w+'| sort | uniq -c Try that again, but skip files matched by the F: clauses. I suspect the matches you get then more closely approximates the K: Russell is suggesting. Andrew