From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code
Date: Thu, 6 Aug 2020 12:56:18 +0300 [thread overview]
Message-ID: <20200806095618.GA1625681@smile.fi.intel.com> (raw)
In-Reply-To: <CANiq72nJgGJJoUoJMxD5LTa-A7Rn1UPnr16nf8DbY9HOy7ZKEA@mail.gmail.com>
On Fri, May 29, 2020 at 11:48:53PM +0200, Miguel Ojeda wrote:
> Hi Andy,
>
> On Mon, May 18, 2020 at 9:36 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > hex_to_bin() may be used to convert hexdecimal digit to its binary
> > representation.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
>
> Looks fine to me and the logic is simpler for the `esc` increase too.
> Thanks for the cleanup! Were you able to test it, by any chance? I
> will queue it up for -rc1.
May I ask which version did you have in mind? Now it's merge window for
v5.9-rc1 and patch is still not there...
> (Sidenote: it would be nice if `git patch` allowed for a full-to-full
> comparison for patches like this since the unified format is harder to
> read; I couldn't find the option from a quick look...).
>
> Cheers,
> Miguel
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-06 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 19:36 [PATCH v1] auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code Andy Shevchenko
2020-05-29 21:48 ` Miguel Ojeda
2020-08-06 9:56 ` Andy Shevchenko [this message]
2020-08-06 14:20 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806095618.GA1625681@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox