From: Heiko Carstens <hca@linux.ibm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Joerg Roedel <jroedel@suse.de>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/Kconfig: add missing ZCRYPT dependency to VFIO_AP
Date: Thu, 6 Aug 2020 13:00:09 +0200 [thread overview]
Message-ID: <20200806110009.GA68234@osiris> (raw)
In-Reply-To: <20200805155053.3739-1-krzk@kernel.org>
On Wed, Aug 05, 2020 at 05:50:53PM +0200, Krzysztof Kozlowski wrote:
> The VFIO_AP uses ap_driver_register() (and deregister) functions
> implemented in ap_bus.c (compiled into ap.o). However the ap.o will be
> built only if CONFIG_ZCRYPT is selected.
>
> This was not visible before commit e93a1695d7fb ("iommu: Enable compile
> testing for some of drivers") because the CONFIG_VFIO_AP depends on
> CONFIG_S390_AP_IOMMU which depends on the missing CONFIG_ZCRYPT. After
> adding COMPILE_TEST, it is possible to select a configuration with
> VFIO_AP and S390_AP_IOMMU but without the ZCRYPT.
>
> Add proper dependency to the VFIO_AP to fix build errors:
>
> ERROR: modpost: "ap_driver_register" [drivers/s390/crypto/vfio_ap.ko] undefined!
> ERROR: modpost: "ap_driver_unregister" [drivers/s390/crypto/vfio_ap.ko] undefined!
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: e93a1695d7fb ("iommu: Enable compile testing for some of drivers")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/s390/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
prev parent reply other threads:[~2020-08-06 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 15:50 [PATCH] s390/Kconfig: add missing ZCRYPT dependency to VFIO_AP Krzysztof Kozlowski
2020-08-06 11:00 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806110009.GA68234@osiris \
--to=hca@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox