Re: [PATCH V2] venus: core: add shutdown callback for venus

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2439 bytes --]

Hi Mansur,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.8 next-20200805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mansur-Alisha-Shaik/venus-core-add-shutdown-callback-for-venus/20200806-114716
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/node.h:18,
                    from include/linux/cpu.h:17,
                    from include/linux/of_device.h:5,
                    from drivers/media/platform/qcom/venus/core.c:11:
   drivers/media/platform/qcom/venus/core.c: In function 'venus_core_shutdown':
>> drivers/media/platform/qcom/venus/core.c:351:23: warning: too many arguments for format [-Wformat-extra-args]
     351 |   dev_warn(core->dev, "shutdown failed \n", ret);
         |                       ^~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/media/platform/qcom/venus/core.c:351:3: note: in expansion of macro 'dev_warn'
     351 |   dev_warn(core->dev, "shutdown failed \n", ret);
         |   ^~~~~~~~

vim +351 drivers/media/platform/qcom/venus/core.c

   343	
   344	static void venus_core_shutdown(struct platform_device *pdev)
   345	{
   346		struct venus_core *core = platform_get_drvdata(pdev);
   347		int ret;
   348	
   349		ret = venus_remove(pdev);
   350		if(ret)
 > 351			dev_warn(core->dev, "shutdown failed \n", ret);
   352	}
   353	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55751 bytes --]