From: Vaibhav Agarwal <vaibhav.sr@gmail.com>
To: Alex Elder <elder@ieee.org>
Cc: Colin Ian King <colin.king@canonical.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Greer <mgreer@animalcreek.com>,
greybus-dev@lists.linaro.org,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put
Date: Thu, 6 Aug 2020 21:47:25 +0530 [thread overview]
Message-ID: <20200806161723.GA6927@gmail.com> (raw)
In-Reply-To: <07ad3809-de73-9a66-0e4f-3a49f395a98a@ieee.org>
On Wed, Aug 05, 2020 at 08:35:15AM -0500, Alex Elder wrote:
<snip>
>
> I think the fix is to add a call to this:
>
> ret = gb_audio_gb_get_control(module->mgmt_connection, data->ctl_id,
> GB_AUDIO_INVALID_INDEX, &gbvalue);
>
> before the field within gbvalue is used.
>
> Looking at gbcodec_mixer_dapm_ctl_get() defined just above that, it
> seems that the call to gb_audio_gb_get_control() should be preceded
> by a call to gb_pm_runtime_get_sync(). And given that duplication,
> I suggest this call and the PM runtime wrapper functions should be
> placed in a new helper function.
>
> I know that Vaibhav said he would be fixing this, so I guess my
> comments are directed at him. Thanks for sending the patch Colin.
>
> -Alex
Thanks Alex. I'll share a patch with the proposed fix.
--
vaibhav
>
>
> > Colin
> >
> >
>
prev parent reply other threads:[~2020-08-06 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 16:02 issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put Colin Ian King
2020-07-31 5:08 ` Vaibhav Agarwal
2020-08-05 13:35 ` Alex Elder
2020-08-06 16:17 ` Vaibhav Agarwal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806161723.GA6927@gmail.com \
--to=vaibhav.sr@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@animalcreek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox