Re: [PATCH v3 15/15] iio: sx9310: Use irq trigger flags from firmware

Andy Shevchenko
2020-07-31T19:47:14Z

On Fri, Jul 31, 2020 at 7:49 PM Daniel Campello <campello@chromium.org> wrote:
>
> From: Stephen Boyd <swboyd@chromium.org>
>
> We shouldn't need to set default irq trigger flags here as the firmware
> should have properly indicated the trigger type, i.e. level low, in the
> DT or ACPI tables.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Daniel Campello <campello@chromium.org>
> ---
>
> Changes in v3:
> - Added irq trigger flags commit to the series.
>
> Changes in v2: None
>
> drivers/iio/proximity/sx9310.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c
> index a20cd6a4dad729..c41fa7f6558e3f 100644
> --- a/drivers/iio/proximity/sx9310.c
> +++ b/drivers/iio/proximity/sx9310.c
> @@ -951,7 +951,7 @@ static int sx9310_probe(struct i2c_client *client)
> ret = devm_request_threaded_irq(dev, client->irq,
> sx9310_irq_handler,
> sx9310_irq_thread_handler,
> - IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> + IRQF_ONESHOT,
> "sx9310_event", indio_dev);
> if (ret)
> return ret;
> --
> 2.28.0.163.g6104cc2f0b6-goog
>

--
With Best Regards,
Andy Shevchenko