Re: [PATCH v5 15/15] iio: sx9310: Use irq trigger flags from firmware

Jonathan Cameron
2020-08-06T18:42:56Z

On Mon, 3 Aug 2020 17:58:15 -0600
Daniel Campello <campello@chromium.org> wrote:

> From: Stephen Boyd <swboyd@chromium.org>
>
> We shouldn't need to set default irq trigger flags here as the firmware
> should have properly indicated the trigger type, i.e. level low, in the
> DT or ACPI tables.
>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Daniel Campello <campello@chromium.org>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Series all applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it,

Thanks,

Jonathan

> ---
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
> - Added irq trigger flags commit to the series.
>
> Changes in v2: None
>
> drivers/iio/proximity/sx9310.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c
> index a68766708fb304..db97b5339d0eff 100644
> --- a/drivers/iio/proximity/sx9310.c
> +++ b/drivers/iio/proximity/sx9310.c
> @@ -948,7 +948,7 @@ static int sx9310_probe(struct i2c_client *client)
> ret = devm_request_threaded_irq(dev, client->irq,
> sx9310_irq_handler,
> sx9310_irq_thread_handler,
> - IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> + IRQF_ONESHOT,
> "sx9310_event", indio_dev);
> if (ret)
> return ret;