From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Daniel Díaz" <daniel.diaz@linaro.org>,
tytso@mit.edu, "Qian Cai" <cai@lca.pw>
Subject: Re: [PATCH] arm64: kaslr: Use standard early random function
Date: Fri, 7 Aug 2020 12:09:23 +0100 [thread overview]
Message-ID: <20200807110923.GA5435@sirena.org.uk> (raw)
In-Reply-To: <20200807004904.72893-1-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
On Thu, Aug 06, 2020 at 05:49:04PM -0700, Guenter Roeck wrote:
> Use arch_get_random_seed_long_early() instead of arm64 specific functions
> to solve the problem. As a side effect of this change, the code no longer
> bypasses ARCH_RANDOM, which I consider desirable (after all, ARCH_RANDOM
> was disabled for a reason).
This should be fine since the entire implementation is still static
inline in the header other than the prints in the WARN_ON() which should
never be triggered here so it should be fine.
Reviewed-by: Mark Brown <broonie@kernel.org>
Tested-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-08-07 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 0:49 [PATCH] arm64: kaslr: Use standard early random function Guenter Roeck
2020-08-07 2:17 ` Linus Torvalds
2020-08-07 10:17 ` Mark Rutland
2020-08-07 14:41 ` Guenter Roeck
2020-08-07 11:09 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807110923.GA5435@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=daniel.diaz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox