From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90AD8C433E1 for ; Sat, 8 Aug 2020 05:06:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A76920855 for ; Sat, 8 Aug 2020 05:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbgHHFGZ (ORCPT ); Sat, 8 Aug 2020 01:06:25 -0400 Received: from mga09.intel.com ([134.134.136.24]:1291 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbgHHFGY (ORCPT ); Sat, 8 Aug 2020 01:06:24 -0400 IronPort-SDR: wGKfKHq9ex18F+5zjhqXAAA6zVE6h4EyD0gl6yeMkAGxFgS0YmfRzWjKNX7UieSJRM/lDCMR/V Cxjg/MT/2p3Q== X-IronPort-AV: E=McAfee;i="6000,8403,9706"; a="154400918" X-IronPort-AV: E=Sophos;i="5.75,448,1589266800"; d="scan'208";a="154400918" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2020 22:06:23 -0700 IronPort-SDR: zOIIPvd03rOwBuFsBRe3OPQGX78V6+D/IsczlGRQvTrEDLcXUVo2xor7SfaWtyEIXv+hX84AcL ndDUtMXnQ2Dg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,448,1589266800"; d="scan'208";a="307577088" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.160]) by orsmga002.jf.intel.com with ESMTP; 07 Aug 2020 22:06:23 -0700 Date: Fri, 7 Aug 2020 22:06:23 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Peter Xu , Peter Shier Subject: Re: [PATCH 1/1] kvm: mmu: zap pages when zapping only parent Message-ID: <20200808050623.GA1123@linux.intel.com> References: <20200727203324.2614917-1-bgardon@google.com> <20200804211444.GA31916@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2020 at 08:48:03PM +0200, Paolo Bonzini wrote: > On 05/08/20 19:10, Ben Gardon wrote: > >> > >> Alternatively, what about moving this logic into mmu_page_zap_pte()? That > >> can be done with a little massaging of FNAME(invlpg) and would avoid what is > >> effectively redundant checks on is_shadow_present_pte() and is_last_spte(). > >> Patches attached and somewhat tested. > > That seems like a good change to me and the patches you attached look > > good to me. I'm happy to review them more if you want to send them to > > the mailing list as their own series. Thanks for putting them > > together. > > > > Thanks, I'll wait for that. Sorry for the delay, been buried with internal stuff. I'll get the series posted on Monday.